Review 11.5 Merged

77332[TASK] Reduce sql queries for page link generation

Benni Mack CR +2 V +2 Normal +144 −6 updated 01/10/23, 09:46

Commit message

Generating a page link leads to 2 sql queries.

The first query is about a general lookup and
frontend group access check. The second occurs
through PageRouter::generateUri().

By passing a fully resolved and possibly overlayed
page record (as object) to generateUri() instead of
a pageId the second query can be omitted.

Since generateUri() is public we need to make sure
the page record is completely resolved and overlayed
in order to reuse it. This is done with the new Page object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Benni Mack commented on patch set 1 01/10/23, 09:15

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php
  2. Benni Mack commented on patch set 2 01/10/23, 09:16

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/10/23, 09:16

  4. Oliver Hader voted on patch set 2 V +1 CR +1 01/10/23, 09:21

  5. core-ci voted on patch set 2 V -1 01/10/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35634

  6. Benni Mack commented on patch set 3 CR +1 V +1 01/10/23, 09:37

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 01/10/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35637

  8. Benni Mack voted on patch set 3 V +2 CR +2 01/10/23, 09:46

  9. Benni Mack merged patch set 4 01/10/23, 09:46