Review main Merged

77353[BUGFIX] Ensure that formatValue for dates/times returns a string

Markus Klein CR +2 V +2 Easy +4 −3 updated 01/11/23, 15:54

Commit message

The unit tests are adjusted to have strict type checking.

The bug is actually covered with a test already, only the assertion
was wrong.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Markus Klein uploaded patch set 1 01/11/23, 14:42

  2. Christian Kuhn commented on patch set 1 01/11/23, 14:46

    AbstractFormElement.php:190

    : string along the way? at least for main?
  3. core-ci voted on patch set 1 V +1 01/11/23, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35691

  4. Markus Klein uploaded patch set 2 V +1 01/11/23, 14:55

  5. Markus Klein commented on patch set 1 01/11/23, 14:55

    AbstractFormElement.php:190 Reply

    Done
  6. Oliver Klee updated the commit message in patch set 3 01/11/23, 15:02

  7. Oliver Klee voted on patch set 3 CR +1 01/11/23, 15:02

  8. core-ci voted on patch set 2 V +1 01/11/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35692

  9. core-ci voted on patch set 3 V -1 01/11/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35694

  10. Oliver Klee voted on patch set 3 V +1 01/11/23, 15:18

  11. core-ci voted on patch set 3 V +1 01/11/23, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35694

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 01/11/23, 15:22

  13. Oli Bartsch voted on patch set 3 V +2 CR +2 01/11/23, 15:54

  14. Oli Bartsch merged patch set 4 01/11/23, 15:54