Review 11.5 Merged

77354[BUGFIX] Ensure that formatValue for dates/times returns a string

Markus Klein CR +2 V +2 Easy +4 −3 updated 01/11/23, 15:59

Commit message

The unit tests are adjusted to have strict type checking.

The bug is actually covered with a test already, only the assertion
was wrong.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Markus Klein uploaded patch set 1 01/11/23, 14:56

  2. Oliver Klee updated the commit message in patch set 2 01/11/23, 15:02

  3. Oliver Klee voted on patch set 2 CR +1 01/11/23, 15:02

  4. core-ci voted on patch set 1 V +1 01/11/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35693

  5. core-ci voted on patch set 2 V +1 01/11/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35695

  6. Oliver Klee voted on patch set 2 V +1 01/11/23, 15:18

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/11/23, 15:22

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 01/11/23, 15:59

  9. Oli Bartsch merged patch set 3 01/11/23, 15:59