77355[BUGFIX] Avoid double hsc() in NoneElement
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Markus Klein +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1315
-
Christian Kuhn uploaded patch set 1 01/11/23, 15:32
-
Markus Klein voted on patch set 1 V +1 CR +1 01/11/23, 15:35
-
Markus Klein voted on patch set 1 V 0 CR 0 01/11/23, 15:35
-
Markus Klein commented on patch set 1 CR -1 01/11/23, 15:35
IMO the option should stay -
core-ci voted on patch set 1 V +1 01/11/23, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35696
-
Christian Kuhn commented on patch set 1 CR -1 01/11/23, 15:45
according to docs, the hsc() below should vanish ... unsure if we should do that, maybe we should deprecate the pass_content option entirely in main at least. docs has a hint this may be a sec hole, but still ... -
Christian Kuhn commented on patch set 1 01/11/23, 15:56
will abandon: we'll do that differently and will deprecate pass_content in v12. -
Christian Kuhn abandoned the change 01/11/23, 15:56
-
Christian Kuhn restored the change 01/12/23, 12:25
-
Christian Kuhn uploaded patch set 2
CR -1V +101/12/23, 12:35 -
Christian Kuhn voted on patch set 2 V +1 CR +1 01/12/23, 12:36
-
core-ci voted on patch set 2 V +1 01/12/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35720
-
Markus Klein voted on patch set 2 V +1 CR +1 01/12/23, 13:17
-
Oli Bartsch voted on patch set 2 V +2 CR +2 01/12/23, 13:19
-
Oli Bartsch merged patch set 3 01/12/23, 13:20