77362[FEATURE] Outgoing Webhooks for TYPO3
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 50
- Build/Sources/Sass/component/_table.scss+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Classes/Attribute/WebhookMessage.phprenamed+8 −8
- typo3/sysext/core/Classes/Messaging/WebhookMessageInterface.phpnew+30 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rstdeleted+0 −39
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99632-IntroducePHPAttributeToMarkAWebhookMessage.rstnew+49 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99629-Webhooks-OutgoingWebhooksForTYPO3.rst3new+223 −0
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.html+14 −23
- typo3/sysext/webhooks/Classes/ConfigurationModuleProvider/WebhookTypesProvider.phpnew+47 −0
- typo3/sysext/webhooks/Classes/Controller/ManagementController.phpnew+132 −0
- typo3/sysext/webhooks/Classes/DependencyInjection/WebhookCompilerPass.phpnew+142 −0
- typo3/sysext/webhooks/Classes/Factory/WebhookInstructionFactory.phpnew+96 −0
- typo3/sysext/webhooks/Classes/Listener/MessageListener.phpnew+57 −0
- typo3/sysext/webhooks/Classes/Listener/PageModificationListener.phpnew+94 −0
- typo3/sysext/webhooks/Classes/Message/FileAddedMessage.phpnew+56 −0
- typo3/sysext/webhooks/Classes/Message/FileRemovedMessage.phpnew+56 −0
- typo3/sysext/webhooks/Classes/Message/FileUpdatedMessage.phpnew+58 −0
- typo3/sysext/webhooks/Classes/Message/LoginErrorOccurredMessage.phpnew+58 −0
- typo3/sysext/webhooks/Classes/Message/PageModificationMessage.phpnew+66 −0
- typo3/sysext/webhooks/Classes/Message/WebhookMessageFactory.phpnew+42 −0
Show 30 more files
- typo3/sysext/webhooks/Classes/MessageHandler/WebhookMessageHandler.phpnew+101 −0
- typo3/sysext/webhooks/Classes/Model/WebhookInstruction.php3new+92 −0
- typo3/sysext/webhooks/Classes/Model/WebhookType.phpnew+58 −0
- typo3/sysext/webhooks/Classes/Pagination/DemandedArrayPaginator.phpnew+68 −0
- typo3/sysext/webhooks/Classes/Repository/WebhookDemand.phpnew+138 −0
- typo3/sysext/webhooks/Classes/Repository/WebhookRepository.phpnew+177 −0
- typo3/sysext/webhooks/Classes/Tca/ItemsProcFunc/WebhookTypesItemsProcFunc.phpnew+46 −0
- typo3/sysext/webhooks/Classes/WebhookTypesRegistry.phpnew+74 −0
- typo3/sysext/webhooks/Configuration/Backend/Modules.phpnew+23 −0
- typo3/sysext/webhooks/Configuration/TCA/sys_webhook.phpnew+193 −0
- typo3/sysext/webhooks/Configuration/Icons.phpnew+10 −0
- typo3/sysext/webhooks/Configuration/Services.phpnew+20 −0
- typo3/sysext/webhooks/Configuration/Services.yamlnew+38 −0
- typo3/sysext/webhooks/Resources/Private/Language/locallang_db.xlfnew+112 −0
- typo3/sysext/webhooks/Resources/Private/Language/locallang_module_webhooks.xlfnew+90 −0
- typo3/sysext/webhooks/Resources/Private/Partials/Pagination.htmlnew+96 −0
- typo3/sysext/webhooks/Resources/Private/Templates/Management/Overview.htmlnew+305 −0
- typo3/sysext/webhooks/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/webhooks/Tests/Functional/Fixtures/sys_webhooks.csvnew+5 −0
- typo3/sysext/webhooks/Tests/Functional/WebhookExecutionTest.phpnew+134 −0
- typo3/sysext/webhooks/Tests/Unit/Factory/WebhookInstructionFactoryTest.phpnew+136 −0
- typo3/sysext/webhooks/.gitattributesnew+2 −0
- typo3/sysext/webhooks/composer.jsonnew+44 −0
- typo3/sysext/webhooks/ext_emconf.phpnew+19 −0
- typo3/sysext/webhooks/ext_localconf.phpnew+7 −0
- typo3/sysext/webhooks/ext_tables.sqlnew+14 −0
- typo3/sysext/webhooks/LICENSE.txtnew+339 −0
- typo3/sysext/webhooks/README.rstnew+12 −0
- composer.json+3 −0
- composer.lock+1 −1
Review log 95144
Show 79119 earlier messages
-
Frank Nägler uploaded patch set 1 01/11/23, 23:14
-
Frank Nägler uploaded patch set 2 01/12/23, 08:03
-
Frank Nägler uploaded patch set 3 01/13/23, 10:26
-
Frank Nägler uploaded patch set 4 01/13/23, 10:56
-
Frank Nägler uploaded patch set 5 01/13/23, 12:55
-
Frank Nägler uploaded patch set 6 01/13/23, 23:00
-
Frank Nägler uploaded patch set 7 01/17/23, 18:48
-
Frank Nägler uploaded patch set 8 01/17/23, 19:46
-
Frank Nägler uploaded patch set 9 01/18/23, 12:12
-
Frank Nägler uploaded patch set 10 01/18/23, 13:15
-
Frank Nägler uploaded patch set 11 01/18/23, 20:34
-
Frank Nägler updated the commit message in patch set 12 01/18/23, 20:38
-
Frank Nägler wrote 01/19/23, 08:49
Unset private -
Frank Nägler uploaded patch set 13 01/19/23, 08:50
-
Frank Nägler marked it work in progress 01/19/23, 08:52
-
core-ci voted on patch set 13 V -1 01/19/23, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36171
-
Frank Nägler uploaded patch set 14
V -101/19/23, 12:56 -
core-ci voted on patch set 14 V -1 01/19/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36238
-
Benjamin Franzke uploaded patch set 15
V -101/22/23, 19:14 -
core-ci voted on patch set 15 V -1 01/22/23, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36432
-
Benjamin Franzke uploaded patch set 16
V -101/22/23, 19:34 -
core-ci voted on patch set 16 V -1 01/22/23, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36437
-
Benjamin Franzke uploaded patch set 17
V -101/22/23, 20:07 -
core-ci voted on patch set 17 V +1 01/22/23, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36438
-
Frank Nägler commented on patch set 17 CR -1 01/24/23, 11:32
This change is ready for review.On it, creating tests and RST file -
Frank Nägler uploaded patch set 18
CR -1V +101/24/23, 14:46 -
Georg Ringer commented on patch set 18 01/24/23, 14:51
PlainJsonElement.php:29what about moving that to public API? i need such thing all the time and as we have even native json sql type, that would perfectly fit together! -
Frank Nägler marked it work in progress 01/24/23, 14:54
-
Frank Nägler commented on patch set 18 01/24/23, 14:55
This change is ready for review.PlainJsonElement.php:29ReplyWe can also move this into core or backend, not sure. I have to add a validator, that is missing in this patch too. -
Frank Nägler marked it work in progress 01/24/23, 14:56
-
core-ci voted on patch set 18 V -1 01/24/23, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36558
-
Andreas Kienast uploaded patch set 19
V -101/26/23, 09:59 -
core-ci voted on patch set 19 V -1 01/26/23, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36644
-
Frank Nägler commented on patch set 19 CR +1 01/27/23, 08:22
on it, finalize the tests -
Frank Nägler voted on patch set 19 CR -1 01/27/23, 08:22
-
Frank Nägler uploaded patch set 20
CR -1V -101/27/23, 10:02 -
core-ci voted on patch set 20 V -1 01/27/23, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36682
-
core-ci commented on patch set 20 01/27/23, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36682
-
Frank Nägler uploaded patch set 21
V -101/27/23, 11:04 -
core-ci voted on patch set 21 V +1 01/27/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36688
-
Frank Nägler uploaded patch set 22
V +102/09/23, 09:04 -
core-ci voted on patch set 22 V +1 02/09/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37431
-
Frank Nägler uploaded patch set 23
V +103/13/23, 11:11 -
Frank Nägler commented on patch set 23 03/13/23, 11:11
PlainJsonElement.php:29ReplyDone -
core-ci voted on patch set 23 V -1 03/13/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38874
-
Frank Nägler uploaded patch set 24
V -103/15/23, 16:08 -
core-ci voted on patch set 24 V +1 03/15/23, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38994
-
Chris Müller uploaded patch set 25
V +103/15/23, 18:42 -
core-ci voted on patch set 25 V +1 03/15/23, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39000
-
Georg Ringer commented on patch set 25 03/15/23, 19:48
This change is ready for review.WebhookInstruction.php:22just from reading: what about using real properties instead of just using the array? that would make it easier to populate the object, also in the factory as there are real type hints, ... -
Frank Nägler commented on patch set 25 CR -1 03/16/23, 10:21
on itWebhookInstruction.php:22ReplyI agree, that is a leftover from the first iteration. -
Frank Nägler uploaded patch set 26
CR -1V +103/16/23, 10:42 -
Frank Nägler commented on patch set 26 03/16/23, 10:45
WebhookInstruction.php:22ReplyDone -
core-ci voted on patch set 26 V -1 03/16/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39050
-
Georg Ringer commented on patch set 26 03/16/23, 10:58
Feature-99629-Webhooks-OutgoingWebhooksForTYPO3.rst:99is this still the way? do we need the create at all? I suggest to use here as well the new WebhookInstruction() also below -
Frank Nägler commented on patch set 26 03/16/23, 11:04
Feature-99629-Webhooks-OutgoingWebhooksForTYPO3.rst:99ReplyI have no hard opinion here. Oliver Bartsch will maybe do some changes on the patch (I am out for the rest of the day), @Oliver if you have the same opinion we can remove the factory. It was an idea for a simpler API, but I am fine to skip that. -
Oli Bartsch uploaded patch set 27
V -103/16/23, 11:19 -
core-ci voted on patch set 27 V +1 03/16/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39052
-
Oli Bartsch uploaded patch set 28
V +103/21/23, 13:06 -
Oli Bartsch uploaded patch set 29 03/21/23, 13:25
-
Oli Bartsch rebased onto patch set 30 03/21/23, 13:26
-
core-ci voted on patch set 28 V -1 03/21/23, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39321
-
core-ci voted on patch set 29 V +1 03/21/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39322
-
core-ci voted on patch set 30 V -1 03/21/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39323
-
Oli Bartsch uploaded patch set 31
V -103/21/23, 16:26 -
core-ci voted on patch set 31 V +1 03/21/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39328
-
Oli Bartsch uploaded patch set 32
V +103/21/23, 16:48 -
core-ci voted on patch set 32 V +1 03/21/23, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39330
-
Oli Bartsch uploaded patch set 33
V +103/21/23, 20:08 -
core-ci voted on patch set 33 V +1 03/21/23, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39343
-
Oli Bartsch commented on patch set 33 03/21/23, 20:31
Feature-99629-Webhooks-OutgoingWebhooksForTYPO3.rst:99ReplyI would like to keep the example as it is. Using the Factory should be the suggested way. This allows underlying changes without breaking extension code. See for example https://review.typo3.org/c/Packages/TYPO3.CMS/+/77362/33/typo3/sysext/webhooks/Classes/Factory/WebhookInstructionFactory.php#71, which is a good example of such change. -
Oli Bartsch uploaded patch set 34
V +103/21/23, 21:11 -
core-ci voted on patch set 34 V +1 03/21/23, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39347
-
Benni Mack uploaded patch set 35
V +103/22/23, 11:21 -
core-ci voted on patch set 35 V +1 03/22/23, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39375
-
Andreas Kienast commented on patch set 35 03/22/23, 14:12
WebhookService.php:46AFAICS we compose a simple tuple based on the database records without any further complexity. How do we profit from a cache here? -
Benni Mack commented on patch set 35 03/22/23, 14:32
WebhookService.php:46ReplyOne DB query vs. 1 Cache Entry reading (fIle-based by default). Much faster -
Benni Mack commented on patch set 35 03/22/23, 14:32
WebhookService.php:46ReplyDone -
Frank Nägler uploaded patch set 36
V +103/22/23, 15:20 -
core-ci voted on patch set 36 V -1 03/22/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39391
-
Frank Nägler uploaded patch set 37
V -103/22/23, 15:48 -
core-ci voted on patch set 37 V -1 03/22/23, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39398
-
Frank Nägler uploaded patch set 38
V -103/22/23, 17:46 -
core-ci voted on patch set 38 V -1 03/22/23, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39406
-
Benni Mack uploaded patch set 39
V -103/22/23, 20:25 -
core-ci voted on patch set 39 V +1 03/22/23, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39416
-
Stefan Bürk commented on patch set 39 CR -1 03/22/23, 20:37
on it (reviewing/testing) ... -
Stefan Bürk uploaded patch set 40
CR -1V +103/22/23, 23:57 -
core-ci voted on patch set 40 V +1 03/23/23, 00:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39428
-
Frank Nägler commented on patch set 40 CR -1 03/23/23, 08:25
on it again -
Benni Mack commented on patch set 40 03/23/23, 08:53
I think we should not use PSR-14 events, but just use the EXT:webhooks extension to add EventListeners that trigger custom webhooks. This way, we can define the payload per use-case. The main benefit of the extension is then to a) ship a set of let's say 10 Webhook Messages (webhook type) that make a payload out of a PSR-14 event message. b) have a GUI for admins to define the endpoints etc. -
Frank Nägler uploaded patch set 41
CR -1V +103/23/23, 11:03 -
Frank Nägler commented on patch set 41 CR -1 03/23/23, 11:06
still not ready -
core-ci voted on patch set 41 V +1 03/23/23, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39460
-
Benni Mack uploaded patch set 42
CR -1V +103/23/23, 15:23 -
core-ci voted on patch set 42 V -1 03/23/23, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39480
-
Benni Mack uploaded patch set 43
V -103/23/23, 16:57 -
core-ci voted on patch set 43 V -1 03/23/23, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39486
-
Benni Mack uploaded patch set 44
V -103/23/23, 20:41 -
Benni Mack uploaded patch set 45 03/23/23, 21:08
-
core-ci voted on patch set 44 V -1 03/23/23, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39494
-
core-ci voted on patch set 45 V -1 03/23/23, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39497
-
Benni Mack uploaded patch set 46
V -103/23/23, 22:22 -
core-ci voted on patch set 46 V -1 03/23/23, 22:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39499
-
Benni Mack uploaded patch set 47
V -103/23/23, 22:43 -
Michael Schams wrote 03/23/23, 22:44
Removed cc Michael Schams. -
core-ci voted on patch set 47 V -1 03/23/23, 22:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39503
-
Benni Mack uploaded patch set 48
V -103/23/23, 23:12 -
core-ci voted on patch set 48 V +1 03/23/23, 23:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39505
-
Stefan Bürk commented on patch set 43 03/24/23, 00:47
GenericWebhookMessage.php:23I guess this should be a `abstract` class then ... does not make much sense to instantiate this class directly. -
Susi Moog commented on patch set 48 CR -1 03/24/23, 09:00
on it -
Susi Moog uploaded patch set 49
CR -1V +103/24/23, 10:35 -
core-ci voted on patch set 49 V +1 03/24/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39536
-
Susi Moog commented on patch set 49 03/24/23, 10:50
GenericWebhookMessage.php:23Replyreworked it a bit, no more abstract class. -
Benni Mack uploaded patch set 50
V +103/24/23, 12:58 -
Benni Mack commented on patch set 50 03/24/23, 13:03
GenericWebhookMessage.php:23ReplyDone -
core-ci voted on patch set 50 V +1 03/24/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39546
-
Benni Mack uploaded patch set 51
V +103/24/23, 13:34 -
core-ci voted on patch set 51 V +1 03/24/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39550
-
Susi Moog uploaded patch set 52
V +103/24/23, 13:55 -
core-ci voted on patch set 52 V +1 03/24/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39554
-
Susi Moog uploaded patch set 53
V +103/24/23, 14:25 -
core-ci voted on patch set 53 V +1 03/24/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39559
-
Susi Moog updated the commit message in patch set 54
V +103/24/23, 15:01 -
Susi Moog updated the commit message in patch set 55 03/24/23, 15:04
-
Benni Mack uploaded patch set 56 03/24/23, 15:11
-
core-ci voted on patch set 54 V +1 03/24/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39563
-
core-ci voted on patch set 55 V -1 03/24/23, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39564
-
core-ci voted on patch set 56 V -1 03/24/23, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39567
-
Benni Mack uploaded patch set 57
V -103/24/23, 19:53 -
Benni Mack voted on patch set 57 V +1 CR +1 03/24/23, 19:53
-
core-ci voted on patch set 57 V -1 03/24/23, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39591
-
Benni Mack uploaded patch set 58
CR +1V +103/24/23, 20:31 -
Benni Mack voted on patch set 58 V +1 CR +1 03/24/23, 20:31
-
core-ci voted on patch set 58 V +1 03/24/23, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39599
-
Benni Mack uploaded patch set 59
CR +1V +103/24/23, 20:53 -
core-ci voted on patch set 59 V +1 03/24/23, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39601
-
Oli Bartsch uploaded patch set 60
V +103/24/23, 21:04 -
Oli Bartsch voted on patch set 60 V +1 CR +1 03/24/23, 21:08
-
Benni Mack voted on patch set 60 V +1 CR +1 03/24/23, 21:09
-
Stefan Bürk voted on patch set 60 CR -1 03/24/23, 21:09
-
core-ci voted on patch set 60 V +1 03/24/23, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39602
-
Stefan Bürk voted on patch set 60 V +2 CR +2 03/24/23, 21:28
-
Stefan Bürk merged patch set 61 03/24/23, 21:28