Review main Merged

77364[FEATURE] Basic TypoScript syntax scanner

Christian Kuhn CR +2 V +2 Hard +530 −3 updated 03/20/23, 15:37

Commit message

This patch adds a last feature to the PageTsConfig and
TypoScript UI in TYPO3 v12. A simple syntax scanner:
* Detect missing and excess braces
* Detect invalid lines - for instance "foo <" which
  missses an identifier stream on the right side.

This is a basic set, the main visitor can be extended
later to look for additional details, for instance
looking for @import lines that can't find any includes.

The patch introduces the main logic. Note the "source"
display is a bit fiddly currently, it mirrors some
issues from the existing "source" display of included
nodes: This area should receive fine additional fine
tuning patches.

Apart from that, the patch finally brings a ReST file
about the new / refactored PageTsConfig and TypoScript
modules.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 1219

  1. Christian Kuhn uploaded patch set 1 01/12/23, 11:58

  2. Christian Kuhn commented on patch set 1 CR -1 01/12/23, 11:59

    need to fix some rendering bugs in analyzer first.
  3. core-ci voted on patch set 1 V -1 01/12/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35719

  4. Christian Kuhn uploaded patch set 2 CR -1 V -1 03/16/23, 07:29

  5. Christian Kuhn uploaded patch set 3 03/16/23, 07:31

  6. core-ci voted on patch set 2 V -1 03/16/23, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39037

  7. core-ci voted on patch set 3 V -1 03/16/23, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39038

  8. Christian Kuhn uploaded patch set 4 V -1 03/20/23, 10:45

  9. core-ci voted on patch set 4 V +1 03/20/23, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39230

  10. Christian Kuhn uploaded patch set 5 V +1 03/20/23, 12:14

  11. core-ci voted on patch set 5 V +1 03/20/23, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39233

  12. Stefan Bürk voted on patch set 5 V +1 03/20/23, 13:17

  13. Stefan Bürk commented on patch set 6 V +1 03/20/23, 14:07

    Published edit on patch set 5.
  14. Stefan Bürk voted on patch set 6 V +1 CR +1 03/20/23, 14:21

  15. core-ci voted on patch set 6 V -1 03/20/23, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39242

  16. core-ci voted on patch set 6 V +1 03/20/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39242

  17. Benni Mack voted on patch set 6 V +1 CR +1 03/20/23, 15:37

  18. Christian Kuhn voted on patch set 6 V +2 CR +2 03/20/23, 15:37

  19. Christian Kuhn merged patch set 7 03/20/23, 15:37