Review main Merged

77366[FEATURE] Improve performance and usability on editing sys_file_collection

Georg Ringer CR +2 V +2 Hard +349 −64 updated 01/19/23, 16:51

Commit message

Use the TCA type `folder` for `sys_file_collection`
records with record type "folder" to select a folder.

This requires to migrate previously used fields
"storage" and "folder" to the new "folder_identifier"
field, which now contains the combined identifier
(storage:folder-path).

A upgrade wizard is in place to migrate existing records.

Previously used itemsProcFunc is marked as deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 1624

  1. Georg Ringer uploaded patch set 1 01/12/23, 13:25

  2. Georg Ringer commented on patch set 1 01/12/23, 13:25

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 01/12/23, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35724

  4. Georg Ringer uploaded patch set 2 V -1 01/12/23, 15:31

  5. core-ci voted on patch set 2 V -1 01/12/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35730

  6. Oliver Klee commented on patch set 2 01/12/23, 16:53

    FolderBasedFileCollection.php:114

    This should be intExplode.
  7. Georg Ringer uploaded patch set 3 V -1 01/12/23, 17:31

  8. Georg Ringer commented on patch set 2 01/12/23, 17:31

    FolderBasedFileCollection.php:114 Reply

    as the folder is a string, the intexplode won't fit
  9. core-ci voted on patch set 3 V -1 01/12/23, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35734

  10. Oliver Klee wrote 01/12/23, 17:45

    Removed cc Oliver Klee.
  11. Georg Ringer uploaded patch set 4 V -1 01/12/23, 17:47

  12. core-ci voted on patch set 4 V -1 01/12/23, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35735

  13. Georg Ringer uploaded patch set 5 V -1 01/12/23, 18:09

  14. core-ci voted on patch set 5 V +1 01/12/23, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35736

  15. Oli Bartsch commented on patch set 5 CR -1 01/13/23, 08:59

    Great patch. This will really improve the UX of this record type.

    Deprecation-97923-DeprecateUserFileMountService.rst:14

    TYPO3 v13.

    Deprecation-97923-DeprecateUserFileMountService.rst:20

    the class?

    Deprecation-97923-DeprecateUserFileMountService.rst:38

    Let's adjust the example a bit to match the use case.

    Deprecation-97923-DeprecateUserFileMountService.rst:48

    What's the reason for referencing this issue here?

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:16

    That's why I would like to have the field called "identifier" instead. Like it's also the case for sys_filemounts.

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:22

    is used in the backend editing form to allow selecting the corresponding folder via the folder selector.

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:28

    record type

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:30

    two whitespaces

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:31

    selector

    SysFileCollectionIdentifierMigration.php:25

    Please lets cover the upgrade wizard with proper tests.
  16. Georg Ringer uploaded patch set 6 CR -1 V +1 01/13/23, 18:34

  17. core-ci voted on patch set 6 V -1 01/13/23, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35775

  18. Georg Ringer uploaded patch set 7 V -1 01/13/23, 19:19

  19. core-ci voted on patch set 7 V +1 01/13/23, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35778

  20. Oli Bartsch uploaded patch set 8 V +1 01/19/23, 15:53

  21. Oli Bartsch commented on patch set 8 V +1 CR +1 01/19/23, 15:54

    Deprecation-97923-DeprecateUserFileMountService.rst:14 Reply

    Done

    Deprecation-97923-DeprecateUserFileMountService.rst:20 Reply

    Done

    Deprecation-97923-DeprecateUserFileMountService.rst:38 Reply

    Done

    Deprecation-97923-DeprecateUserFileMountService.rst:48 Reply

    Done

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:16 Reply

    Done

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:22 Reply

    Done

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:28 Reply

    Done

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:30 Reply

    Done

    Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:31 Reply

    Done

    SysFileCollectionIdentifierMigration.php:25 Reply

    Done
  22. core-ci voted on patch set 8 V +1 01/19/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36264

  23. Benni Mack voted on patch set 8 V +2 CR +2 01/19/23, 16:50

  24. Benni Mack merged patch set 9 01/19/23, 16:51