77366[FEATURE] Improve performance and usability on editing sys_file_collection
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/core/Classes/Resource/Collection/FolderBasedFileCollection.php2+5 −5
- typo3/sysext/core/Classes/Resource/Service/UserFileMountService.php+8 −1
- typo3/sysext/core/Classes/Resource/SynchronizeFolderRelations.php+6 −8
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+6 −21
- typo3/sysext/core/Documentation/Changelog/12.2/Deprecation-97923-DeprecateUserFileMountService.rst8new+51 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst10new+42 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FileCollectionBase.csv+10 −10
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/FileCollectionResult.csv+10 −10
- typo3/sysext/core/Tests/Functional/Tca/FileCollectionVisibleFieldsTest.php+1 −2
- typo3/sysext/core/ext_tables.sql+1 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/DataSet/FilesContentObjectDataSet.csv+4 −4
- typo3/sysext/install/Classes/Updates/SysFileCollectionIdentifierMigration.php2new+116 −0
- typo3/sysext/install/Classes/Updates/SysFileMountIdentifierMigration.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/FileCollectionBase.csvnew+8 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/FileCollectionMigrated.csvnew+8 −0
- typo3/sysext/install/Tests/Functional/Updates/SysFileCollectionIdentifierMigrationTest.phpnew+67 −0
Review log 1624
-
Georg Ringer uploaded patch set 1 01/12/23, 13:25
-
Georg Ringer commented on patch set 1 01/12/23, 13:25
This change is ready for review. -
core-ci voted on patch set 1 V -1 01/12/23, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35724
-
Georg Ringer uploaded patch set 2
V -101/12/23, 15:31 -
core-ci voted on patch set 2 V -1 01/12/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35730
-
Oliver Klee commented on patch set 2 01/12/23, 16:53
FolderBasedFileCollection.php:114This should be intExplode. -
Georg Ringer uploaded patch set 3
V -101/12/23, 17:31 -
Georg Ringer commented on patch set 2 01/12/23, 17:31
FolderBasedFileCollection.php:114Replyas the folder is a string, the intexplode won't fit -
core-ci voted on patch set 3 V -1 01/12/23, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35734
-
Oliver Klee wrote 01/12/23, 17:45
Removed cc Oliver Klee. -
Georg Ringer uploaded patch set 4
V -101/12/23, 17:47 -
core-ci voted on patch set 4 V -1 01/12/23, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35735
-
Georg Ringer uploaded patch set 5
V -101/12/23, 18:09 -
core-ci voted on patch set 5 V +1 01/12/23, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35736
-
Oli Bartsch commented on patch set 5 CR -1 01/13/23, 08:59
Great patch. This will really improve the UX of this record type.Deprecation-97923-DeprecateUserFileMountService.rst:14TYPO3 v13.Deprecation-97923-DeprecateUserFileMountService.rst:20the class?Deprecation-97923-DeprecateUserFileMountService.rst:38Let's adjust the example a bit to match the use case.Deprecation-97923-DeprecateUserFileMountService.rst:48What's the reason for referencing this issue here?Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:16That's why I would like to have the field called "identifier" instead. Like it's also the case for sys_filemounts.Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:22is used in the backend editing form to allow selecting the corresponding folder via the folder selector.Feature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:28record typeFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:30two whitespacesFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:31selectorSysFileCollectionIdentifierMigration.php:25Please lets cover the upgrade wizard with proper tests. -
Georg Ringer uploaded patch set 6
CR -1V +101/13/23, 18:34 -
core-ci voted on patch set 6 V -1 01/13/23, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35775
-
Georg Ringer uploaded patch set 7
V -101/13/23, 19:19 -
core-ci voted on patch set 7 V +1 01/13/23, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35778
-
Oli Bartsch uploaded patch set 8
V +101/19/23, 15:53 -
Oli Bartsch commented on patch set 8 V +1 CR +1 01/19/23, 15:54
Deprecation-97923-DeprecateUserFileMountService.rst:14ReplyDoneDeprecation-97923-DeprecateUserFileMountService.rst:20ReplyDoneDeprecation-97923-DeprecateUserFileMountService.rst:38ReplyDoneDeprecation-97923-DeprecateUserFileMountService.rst:48ReplyDoneFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:16ReplyDoneFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:22ReplyDoneFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:28ReplyDoneFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:30ReplyDoneFeature-97923-ImprovePerformanceAndUsabilityWhileEditingSys_file_collection.rst:31ReplyDoneSysFileCollectionIdentifierMigration.php:25ReplyDone -
core-ci voted on patch set 8 V +1 01/19/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36264
-
Benni Mack voted on patch set 8 V +2 CR +2 01/19/23, 16:50
-
Benni Mack merged patch set 9 01/19/23, 16:51