Review main Merged

77368[TASK] Update tree layout in "Included TypoScript"

Christian Kuhn CR +2 V +2 Hard +577 −401 updated 01/20/23, 21:10

Commit message

This is about module "TypoScript" -> "Included TypoScript",
formerly known as "Template Analyzer":

* The table is moved to an ul/li structure
* ul/li tree is collapsible and remembers state in
  browser local storage
* Optimization of tree node descriptions, added badges
  with additional information
* Source rendering in a modal
* Various label adaptions

There are a couple of minor issues left, to be fixed
with small additional changes:

* Collapse / expand icon state not clean
* Source modal may show scrollbar too often
* Optimization of rendered source
* Issues when t3editor extension does not exist
* Main drop down may loose state
* Condition source rendering is hard to grasp

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 3257

Show 1832 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/12/23, 20:45

  2. core-ci voted on patch set 1 V +1 01/12/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35737

  3. Christian Kuhn commented on patch set 1 CR -1 01/12/23, 20:57

    needs pre-patch.
  4. Benjamin Franzke uploaded patch set 2 CR -1 V +1 01/17/23, 12:41

  5. core-ci voted on patch set 2 V +1 01/17/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35954

  6. Jasmina Ließmann uploaded patch set 3 V +1 01/17/23, 15:28

  7. core-ci voted on patch set 3 V +1 01/17/23, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35975

  8. Benjamin Franzke uploaded patch set 4 V +1 01/17/23, 15:46

  9. Jasmina Ließmann updated the commit message in patch set 5 01/17/23, 15:50

  10. core-ci voted on patch set 4 V +1 01/17/23, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35976

  11. core-ci voted on patch set 5 V +1 01/17/23, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35977

  12. Jasmina Ließmann uploaded patch set 6 V +1 01/19/23, 11:02

  13. Jasmina Ließmann uploaded patch set 7 01/19/23, 11:22

  14. core-ci voted on patch set 6 V +1 01/19/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36196

  15. core-ci voted on patch set 7 V +1 01/19/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36201

  16. Jasmina Ließmann uploaded patch set 8 V +1 01/19/23, 12:18

  17. Jasmina Ließmann uploaded patch set 9 01/19/23, 12:28

  18. Jasmina Ließmann uploaded patch set 10 01/19/23, 13:07

  19. core-ci voted on patch set 9 V -1 01/19/23, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36230

  20. core-ci voted on patch set 10 V -1 01/19/23, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36242

  21. Jasmina Ließmann uploaded patch set 11 01/20/23, 13:20

    Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE")
  22. Jasmina Ließmann uploaded patch set 12 V -1 01/20/23, 13:26

  23. core-ci voted on patch set 11 V -1 01/20/23, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36348

  24. Jasmina Ließmann uploaded patch set 13 01/20/23, 13:45

  25. core-ci voted on patch set 12 V -1 01/20/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36351

  26. Jasmina Ließmann uploaded patch set 14 01/20/23, 13:49

  27. Christian Kuhn wrote 01/20/23, 13:53

    Removed cc Oli Bartsch.
  28. Jasmina Ließmann updated the commit message in patch set 15 01/20/23, 13:54

  29. core-ci voted on patch set 13 V -1 01/20/23, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36357

  30. Jasmina Ließmann uploaded patch set 16 01/20/23, 14:35

  31. core-ci voted on patch set 14 V -1 01/20/23, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36361

  32. core-ci voted on patch set 15 V -1 01/20/23, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36362

  1. core-ci voted on patch set 16 V -1 01/20/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36369

  2. Christian Kuhn uploaded patch set 17 V -1 01/20/23, 17:44

  3. core-ci voted on patch set 17 V -1 01/20/23, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36378

  4. Jasmina Ließmann uploaded patch set 18 V -1 01/20/23, 18:15

  5. Christian Kuhn uploaded patch set 19 01/20/23, 18:19

  6. Jasmina Ließmann uploaded patch set 20 01/20/23, 18:27

  7. core-ci voted on patch set 18 V -1 01/20/23, 18:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36379

  8. core-ci voted on patch set 19 V -1 01/20/23, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36380

  9. core-ci voted on patch set 20 V -1 01/20/23, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36381

  10. Christian Kuhn uploaded patch set 21 V -1 01/20/23, 18:59

  11. core-ci voted on patch set 21 V -1 01/20/23, 19:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36382

  12. Jasmina Ließmann uploaded patch set 22 V -1 01/20/23, 19:47

  13. Christian Kuhn uploaded patch set 23 01/20/23, 19:56

  14. core-ci voted on patch set 22 V -1 01/20/23, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36383

  15. core-ci voted on patch set 23 V -1 01/20/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36384

  16. Jasmina Ließmann uploaded patch set 24 V -1 01/20/23, 20:22

  17. core-ci voted on patch set 24 V -1 01/20/23, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36385

  18. Christian Kuhn uploaded patch set 25 V -1 01/20/23, 20:33

  19. Christian Kuhn updated the commit message in patch set 26 01/20/23, 20:36

  20. core-ci voted on patch set 25 V +1 01/20/23, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36386

  21. core-ci voted on patch set 26 V +1 01/20/23, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36387

  22. Stefan Bürk commented on patch set 26 V +1 CR +1 01/20/23, 20:56

    There are minor issues left, as already stated in the commit message. Fine with getting this basic refactor in in current state, to avoid on going merge conflicts. Even if not finally finished. At least it is usable for now. Beside this .. love this patch and the overworked view and where this is going to.
  23. Jasmina Ließmann voted on patch set 26 V +1 CR +1 01/20/23, 21:09

  24. Christian Kuhn voted on patch set 26 V +2 CR +2 01/20/23, 21:10

  25. Christian Kuhn merged patch set 27 01/20/23, 21:10