77368[TASK] Update tree layout in "Included TypoScript"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 23
- Build/Sources/Sass/module/_tstemplate.scss+12 −0
- Build/Sources/Sass/typo3/_element_tree.scss+1 −1
- Build/Sources/TypeScript/tstemplate/template-analyzer.tsnew+59 −0
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+9 −9
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+2 −2
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+24 −24
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+86 −65
- typo3/sysext/tstemplate/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeNodeFinderVisitor.phpnew+54 −0
- typo3/sysext/tstemplate/Configuration/Backend/Modules.php+7 −2
- typo3/sysext/tstemplate/Configuration/JavaScriptModules.php+4 −0
- typo3/sysext/tstemplate/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_analyzer.xlf+100 −49
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_info.xlf+1 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerConditions.html+4 −4
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerOptions.html+1 −22
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerSource.htmldeleted+0 −22
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerTree.html+123 −87
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerTreePanel.html+11 −38
Review log 3257
Show 1832 earlier messages
-
Christian Kuhn uploaded patch set 1 01/12/23, 20:45
-
core-ci voted on patch set 1 V +1 01/12/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35737
-
Christian Kuhn commented on patch set 1 CR -1 01/12/23, 20:57
needs pre-patch. -
Benjamin Franzke uploaded patch set 2
CR -1V +101/17/23, 12:41 -
core-ci voted on patch set 2 V +1 01/17/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35954
-
Jasmina Ließmann uploaded patch set 3
V +101/17/23, 15:28 -
core-ci voted on patch set 3 V +1 01/17/23, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35975
-
Benjamin Franzke uploaded patch set 4
V +101/17/23, 15:46 -
Jasmina Ließmann updated the commit message in patch set 5 01/17/23, 15:50
-
core-ci voted on patch set 4 V +1 01/17/23, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35976
-
core-ci voted on patch set 5 V +1 01/17/23, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35977
-
Jasmina Ließmann uploaded patch set 6
V +101/19/23, 11:02 -
Jasmina Ließmann uploaded patch set 7 01/19/23, 11:22
-
core-ci voted on patch set 6 V +1 01/19/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36196
-
core-ci voted on patch set 7 V +1 01/19/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36201
-
Jasmina Ließmann uploaded patch set 8
V +101/19/23, 12:18 -
Jasmina Ließmann uploaded patch set 9 01/19/23, 12:28
-
Jasmina Ließmann uploaded patch set 10 01/19/23, 13:07
-
core-ci voted on patch set 9 V -1 01/19/23, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36230
-
core-ci voted on patch set 10 V -1 01/19/23, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36242
-
Jasmina Ließmann uploaded patch set 11 01/20/23, 13:20
Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE") -
Jasmina Ließmann uploaded patch set 12
V -101/20/23, 13:26 -
core-ci voted on patch set 11 V -1 01/20/23, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36348
-
Jasmina Ließmann uploaded patch set 13 01/20/23, 13:45
-
core-ci voted on patch set 12 V -1 01/20/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36351
-
Jasmina Ließmann uploaded patch set 14 01/20/23, 13:49
-
Christian Kuhn wrote 01/20/23, 13:53
Removed cc Oli Bartsch. -
Jasmina Ließmann updated the commit message in patch set 15 01/20/23, 13:54
-
core-ci voted on patch set 13 V -1 01/20/23, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36357
-
Jasmina Ließmann uploaded patch set 16 01/20/23, 14:35
-
core-ci voted on patch set 14 V -1 01/20/23, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36361
-
core-ci voted on patch set 15 V -1 01/20/23, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36362
-
core-ci voted on patch set 16 V -1 01/20/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36369
-
Christian Kuhn uploaded patch set 17
V -101/20/23, 17:44 -
core-ci voted on patch set 17 V -1 01/20/23, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36378
-
Jasmina Ließmann uploaded patch set 18
V -101/20/23, 18:15 -
Christian Kuhn uploaded patch set 19 01/20/23, 18:19
-
Jasmina Ließmann uploaded patch set 20 01/20/23, 18:27
-
core-ci voted on patch set 18 V -1 01/20/23, 18:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36379
-
core-ci voted on patch set 19 V -1 01/20/23, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36380
-
core-ci voted on patch set 20 V -1 01/20/23, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36381
-
Christian Kuhn uploaded patch set 21
V -101/20/23, 18:59 -
core-ci voted on patch set 21 V -1 01/20/23, 19:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36382
-
Jasmina Ließmann uploaded patch set 22
V -101/20/23, 19:47 -
Christian Kuhn uploaded patch set 23 01/20/23, 19:56
-
core-ci voted on patch set 22 V -1 01/20/23, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36383
-
core-ci voted on patch set 23 V -1 01/20/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36384
-
Jasmina Ließmann uploaded patch set 24
V -101/20/23, 20:22 -
core-ci voted on patch set 24 V -1 01/20/23, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36385
-
Christian Kuhn uploaded patch set 25
V -101/20/23, 20:33 -
Christian Kuhn updated the commit message in patch set 26 01/20/23, 20:36
-
core-ci voted on patch set 25 V +1 01/20/23, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36386
-
core-ci voted on patch set 26 V +1 01/20/23, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36387
-
Stefan Bürk commented on patch set 26 V +1 CR +1 01/20/23, 20:56
There are minor issues left, as already stated in the commit message. Fine with getting this basic refactor in in current state, to avoid on going merge conflicts. Even if not finally finished. At least it is usable for now. Beside this .. love this patch and the overworked view and where this is going to. -
Jasmina Ließmann voted on patch set 26 V +1 CR +1 01/20/23, 21:09
-
Christian Kuhn voted on patch set 26 V +2 CR +2 01/20/23, 21:10
-
Christian Kuhn merged patch set 27 01/20/23, 21:10