77369[TASK] Streamline TypoScript IncludeTree logic
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php+20 −2
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php+20 −2
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/RootInclude.php+0 −6
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionIncludeListAccumulatorVisitor.php+1 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php+2 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateTreeBuilder.php+39 −35
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+102 −49
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+4 −2
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+2 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/IncludeTreeObjectIgnoringIdentifierAndPathComparator.phpnew+41 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+37 −159
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/UnserializedIncludeTreeObjectComparator.php+1 −1
Review log 1117
-
Christian Kuhn uploaded patch set 1 01/13/23, 01:25
-
Christian Kuhn commented on patch set 1 01/13/23, 01:26
needs to be done for template analyzer fixes. -
core-ci voted on patch set 1 V -1 01/13/23, 01:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35739
-
Christian Kuhn uploaded patch set 2
V -101/13/23, 18:43 -
core-ci voted on patch set 2 V +1 01/13/23, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35776
-
Christian Kuhn uploaded patch set 3
V +101/13/23, 19:00 -
core-ci voted on patch set 3 V +1 01/13/23, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35777
-
Christian Kuhn updated the commit message in patch set 4
V +101/13/23, 19:31 -
Christian Kuhn updated the commit message in patch set 5 01/13/23, 19:33
-
core-ci voted on patch set 5 V +1 01/13/23, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35780
-
core-ci voted on patch set 4 V +1 01/13/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35779
-
Christian Kuhn uploaded patch set 6
V +101/13/23, 19:56 -
core-ci voted on patch set 6 V +1 01/13/23, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35782
-
Benni Mack voted on patch set 6 V +1 CR +1 01/14/23, 20:00
-
Stefan Bürk voted on patch set 6 V +1 CR +1 01/15/23, 07:18
-
Christian Kuhn voted on patch set 6 V +2 CR +2 01/16/23, 09:32
-
Christian Kuhn merged patch set 7 01/16/23, 09:32