Review 11.5 Merged

77371[BUGFIX] Fix notice in FrontendConfigurationManager

Georg Ringer CR +2 V +2 Easy +1 −1 updated 01/23/23, 10:28

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 01/13/23, 08:39

  2. Georg Ringer commented on patch set 1 01/13/23, 08:39

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 01/13/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35747

  4. Jörg Bösche commented on patch set 1 CR -1 01/13/23, 09:02

    I'm not happy with the empty string, because of checking for "greater than zero" (integer) Might be possible to use the "int 0" as default value? There shouldn't be a valid page/record on page uid 0, so we can use the 0 as value and having a strict type check in our condition.
  5. Josef Glatz wrote 01/23/23, 05:13

    Removed reviewer Josef Glatz.
  6. Oliver Klee commented on patch set 2 CR -1 V +1 01/23/23, 09:19

    Published edit on patch set 1.
  7. Oliver Klee commented on patch set 2 01/23/23, 09:20

    Reply

    Done.
  8. core-ci voted on patch set 2 V +1 01/23/23, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36454

  9. Oliver Klee voted on patch set 2 CR +1 01/23/23, 09:43

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 01/23/23, 10:13

  11. Nikita Hovratov voted on patch set 2 V +2 CR +2 01/23/23, 10:28

  12. Nikita Hovratov merged patch set 3 01/23/23, 10:28