Review main Merged

77373[TASK] Deprecate backwards-compatibility TYPO3 language keys

Benni Mack CR +2 V +2 Normal +65 −8 updated 01/13/23, 13:09

Commit message

Before TYPO3 v4.0, TYPO3 had inconsistencies
in its language keys, such as "ja" (= Japan)
instead of "jp" (= Japanese), which was still
available.

However, the mapping was only used for
detecting the language from the user agent,
for the backend login screen, and not used
since various versions.

TYPO3 since at least 6.0 only delivers
the correct language keys and the "old"
language keys can now safely be removed,
thus they are deprecated.

The getter method Locales->getIsoMapping()
is marked as deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 810

  1. Benni Mack uploaded patch set 1 01/13/23, 10:49

  2. core-ci voted on patch set 1 V -1 01/13/23, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35754

  3. Georg Ringer voted on patch set 1 V +1 CR +1 01/13/23, 11:15

  4. Josef Glatz commented on patch set 1 V +1 CR +1 01/13/23, 11:28

    +1, no usages found in core
  5. Benni Mack uploaded patch set 2 CR +1 V +1 01/13/23, 12:45

  6. core-ci voted on patch set 2 V +1 01/13/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35761

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/13/23, 13:02

  8. Josef Glatz voted on patch set 2 V +1 CR +1 01/13/23, 13:09

  9. Benni Mack voted on patch set 2 V +2 CR +2 01/13/23, 13:09

  10. Benni Mack merged patch set 3 01/13/23, 13:09