Review main Merged

77378[TASK] Reduce code complexity with language labels in PageRenderer

Benni Mack CR +2 V +2 Normal +31 −66 updated 01/16/23, 09:58

Commit message

PageRenderer has some speciality but also code duplication
from LanguageService and can be simplified this way,
avoid additional parsing states.

This way, LanguageService can be used more instead
of handling language dependencies manually as before.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 711

  1. Benni Mack uploaded patch set 1 01/13/23, 15:11

  2. core-ci voted on patch set 1 V -1 01/13/23, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35768

  3. Benni Mack uploaded patch set 2 V -1 01/13/23, 15:56

  4. core-ci voted on patch set 2 V -1 01/13/23, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35769

  5. Benni Mack uploaded patch set 3 V -1 01/13/23, 22:51

  6. Benni Mack updated the commit message in patch set 4 01/13/23, 22:52

  7. core-ci voted on patch set 3 V +1 01/13/23, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35785

  8. core-ci voted on patch set 4 V +1 01/13/23, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35786

  9. Stefan Bürk voted on patch set 4 V +1 CR +1 01/15/23, 17:42

  10. Georg Ringer voted on patch set 4 V +2 CR +2 01/16/23, 09:58

  11. Georg Ringer merged patch set 5 01/16/23, 09:58