Review main Merged

77380[DOCS] Add hint to HtmlViewHelper about avoiding usage in backend context

Chris Müller CR +2 V +2 Easy +4 −0 updated 01/18/23, 18:40

Commit message

The docblock of the class is rendered for documentation, see:
https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/Format/Html.html

This information should therefore be mentioned.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1317

  1. Chris Müller uploaded patch set 1 01/13/23, 17:49

  2. Chris Müller updated the commit message in patch set 2 01/13/23, 17:51

  3. core-ci voted on patch set 1 V +1 01/13/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35773

  4. core-ci voted on patch set 2 V +1 01/13/23, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35774

  5. Oliver Klee commented on patch set 2 01/13/23, 18:13

    Would it make sense to also have this in the 11.x and 10.x documentation?
  6. Lina Wolf commented on patch set 2 01/14/23, 08:41

    Reply

    I would backport this to the 11.x documentation. We do not maintain the 10.x documentation anymore except in rare exceptions
  7. Chris Müller updated the commit message in patch set 3 V +1 01/14/23, 08:53

  8. Chris Müller commented on patch set 3 01/14/23, 08:53

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 01/14/23, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35793

  10. Lina Wolf commented on patch set 3 01/14/23, 09:10

    HtmlViewHelper.php:37

    I would switch the sentence. This view helper must not be used in frontend content as this and that would be the result.

    HtmlViewHelper.php:40

    I would not recommend format.raw here. if we do recommend it we should link to sources on how to decide what is "secure" HTML input
  11. Chris Müller uploaded patch set 4 V +1 01/18/23, 17:26

  12. Chris Müller commented on patch set 4 01/18/23, 17:26

    HtmlViewHelper.php:37 Reply

    Done

    HtmlViewHelper.php:40 Reply

    Done
  13. Oliver Klee voted on patch set 4 V +1 CR +1 01/18/23, 17:28

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 01/18/23, 17:29

  15. core-ci voted on patch set 4 V +1 01/18/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36133

  16. Nikita Hovratov voted on patch set 4 V +2 CR +2 01/18/23, 18:39

  17. Nikita Hovratov merged patch set 5 01/18/23, 18:40