77387[TASK] Hand over page record to PageLinkBuilder
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+2 −0
- typo3/sysext/core/Classes/Domain/Page.php+21 −3
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+7 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+26 −3
- typo3/sysext/frontend/Classes/Event/ModifyPageLinkConfigurationEvent.php1+8 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+21 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −0
Review log 2539
Show 814 earlier messages
-
Christoph Lehmann uploaded patch set 1 01/14/23, 22:57
-
Christoph Lehmann wrote 01/14/23, 22:57
Set private -
Christoph Lehmann wrote 01/14/23, 23:03
Unset private -
core-ci voted on patch set 1 V -1 01/14/23, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35805
-
Christoph Lehmann uploaded patch set 2
V -101/15/23, 15:11 -
core-ci voted on patch set 2 V -1 01/15/23, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35814
-
Christoph Lehmann rebased onto patch set 3
V -101/17/23, 13:13 -
core-ci voted on patch set 3 V -1 01/17/23, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35962
-
Christoph Lehmann rebased onto patch set 4
V -101/18/23, 10:24 -
core-ci voted on patch set 4 V -1 01/18/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36065
-
Christoph Lehmann uploaded patch set 5
V -101/18/23, 14:24 -
core-ci voted on patch set 5 V -1 01/18/23, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36099
-
Christoph Lehmann uploaded patch set 6
V -101/18/23, 16:01 -
core-ci voted on patch set 6 V -1 01/18/23, 16:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36116
-
Christoph Lehmann uploaded patch set 7
V -101/22/23, 01:33 -
core-ci voted on patch set 7 V -1 01/22/23, 01:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36418
-
Christoph Lehmann uploaded patch set 8
V -101/22/23, 19:13 -
Christoph Lehmann uploaded patch set 9 01/22/23, 19:15
-
core-ci voted on patch set 8 V -1 01/22/23, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36431
-
core-ci voted on patch set 9 V -1 01/22/23, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36433
-
Christoph Lehmann uploaded patch set 10
V -101/23/23, 23:24 -
core-ci voted on patch set 10 V -1 01/23/23, 23:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36501
-
Christoph Lehmann uploaded patch set 11
V -101/24/23, 20:41 -
core-ci voted on patch set 11 V +1 01/24/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36576
-
Christoph Lehmann commented on patch set 11 01/24/23, 20:56
ModifyPageLinkConfigurationEvent.php:28Using such a flag doens't feel 100% good, but ensures that $page is used and not $conf['page'] The event was added some days ago so changes might be okay(?). -
Benni Mack rebased onto patch set 12
V +103/07/23, 16:16 -
core-ci voted on patch set 12 V +1 03/07/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38615
-
Benni Mack commented on patch set 12 03/07/23, 17:21
I think this is pretty much good as is. Ideally we could add a few tests to PageRepository and PageLinkBuilder to ensure we get a Page object back. Is that possible? -
Christoph Lehmann commented on patch set 12 03/08/23, 08:19
Reply
Sure. will do. -
Christoph Lehmann uploaded patch set 13
V +103/12/23, 21:08 -
core-ci voted on patch set 13 V +1 03/12/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38847
-
Benni Mack uploaded patch set 14
V +103/13/23, 21:09 -
core-ci voted on patch set 14 V +1 03/13/23, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38890
-
Benni Mack voted on patch set 14 V +1 CR +1 03/13/23, 21:43
-
Jochen Roth voted on patch set 14 V +1 CR +1 03/14/23, 15:08
-
Benni Mack voted on patch set 14 V +2 CR +2 03/14/23, 15:19
-
Benni Mack merged patch set 15 03/14/23, 15:19
-
Benni Mack commented on patch set 15 03/16/23, 10:21
This patch completely bricks my installation where I have a page with * doktype=3 (external URL) * url="?showOptin=true" and I render this in a HMENU (or CType=menu_sitemap) We have an endless loop. I tried to find the reason for 2hs last night, but wasn't able to do that. Will prepare a revert. -
Benni Mack wrote 03/16/23, 10:49
Created a revert of this change as Ib1885b61aa9c6806eaa30a187c5d292c079879fc