Review main Merged

77387[TASK] Hand over page record to PageLinkBuilder

Christoph Lehmann CR +2 V +2 Normal +88 −8 updated 03/16/23, 10:49

Commit message

Hand over the overlayed page record from
PageRepository::getSubpagesForPages()
to the PageLinkBuilder in order to not fetch and
overlay the target page twice.

This reduces the amount of SQL queries when building menus.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2539

Show 814 earlier messages
  1. Christoph Lehmann uploaded patch set 1 01/14/23, 22:57

  2. Christoph Lehmann wrote 01/14/23, 22:57

    Set private
  3. Christoph Lehmann wrote 01/14/23, 23:03

    Unset private
  4. core-ci voted on patch set 1 V -1 01/14/23, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35805

  5. Christoph Lehmann uploaded patch set 2 V -1 01/15/23, 15:11

  6. core-ci voted on patch set 2 V -1 01/15/23, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35814

  7. Christoph Lehmann rebased onto patch set 3 V -1 01/17/23, 13:13

  8. core-ci voted on patch set 3 V -1 01/17/23, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35962

  9. Christoph Lehmann rebased onto patch set 4 V -1 01/18/23, 10:24

  10. core-ci voted on patch set 4 V -1 01/18/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36065

  11. Christoph Lehmann uploaded patch set 5 V -1 01/18/23, 14:24

  12. core-ci voted on patch set 5 V -1 01/18/23, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36099

  13. Christoph Lehmann uploaded patch set 6 V -1 01/18/23, 16:01

  14. core-ci voted on patch set 6 V -1 01/18/23, 16:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36116

  1. Christoph Lehmann uploaded patch set 7 V -1 01/22/23, 01:33

  2. core-ci voted on patch set 7 V -1 01/22/23, 01:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36418

  3. Christoph Lehmann uploaded patch set 8 V -1 01/22/23, 19:13

  4. Christoph Lehmann uploaded patch set 9 01/22/23, 19:15

  5. core-ci voted on patch set 8 V -1 01/22/23, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36431

  6. core-ci voted on patch set 9 V -1 01/22/23, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36433

  7. Christoph Lehmann uploaded patch set 10 V -1 01/23/23, 23:24

  8. core-ci voted on patch set 10 V -1 01/23/23, 23:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36501

  9. Christoph Lehmann uploaded patch set 11 V -1 01/24/23, 20:41

  10. core-ci voted on patch set 11 V +1 01/24/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36576

  11. Christoph Lehmann commented on patch set 11 01/24/23, 20:56

    ModifyPageLinkConfigurationEvent.php:28

    Using such a flag doens't feel 100% good, but ensures that $page is used and not $conf['page'] The event was added some days ago so changes might be okay(?).
  12. Benni Mack rebased onto patch set 12 V +1 03/07/23, 16:16

  13. core-ci voted on patch set 12 V +1 03/07/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38615

  14. Benni Mack commented on patch set 12 03/07/23, 17:21

    I think this is pretty much good as is. Ideally we could add a few tests to PageRepository and PageLinkBuilder to ensure we get a Page object back. Is that possible?
  15. Christoph Lehmann commented on patch set 12 03/08/23, 08:19

    Reply

    Sure. will do.
  16. Christoph Lehmann uploaded patch set 13 V +1 03/12/23, 21:08

  17. core-ci voted on patch set 13 V +1 03/12/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38847

  18. Benni Mack uploaded patch set 14 V +1 03/13/23, 21:09

  19. core-ci voted on patch set 14 V +1 03/13/23, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38890

  20. Benni Mack voted on patch set 14 V +1 CR +1 03/13/23, 21:43

  21. Jochen Roth voted on patch set 14 V +1 CR +1 03/14/23, 15:08

  22. Benni Mack voted on patch set 14 V +2 CR +2 03/14/23, 15:19

  23. Benni Mack merged patch set 15 03/14/23, 15:19

  24. Benni Mack commented on patch set 15 03/16/23, 10:21

    This patch completely bricks my installation where I have a page with * doktype=3 (external URL) * url="?showOptin=true" and I render this in a HMENU (or CType=menu_sitemap) We have an endless loop. I tried to find the reason for 2hs last night, but wasn't able to do that. Will prepare a revert.
  25. Benni Mack wrote 03/16/23, 10:49

    Created a revert of this change as Ib1885b61aa9c6806eaa30a187c5d292c079879fc