Review main Merged

77391[TASK] Migrate LocalizationUtility Test to Functional

Benni Mack CR +2 V +2 Easy +7 −35 updated 01/16/23, 14:37

Commit message

Avoid heavy mocking in tests by
utilizing Functionals incl. PackageManager
and Caching Framework.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 01/16/23, 14:16

  2. core-ci voted on patch set 1 V +1 01/16/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35854

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 01/16/23, 14:32

  4. Nikita Hovratov voted on patch set 1 V +2 CR +2 01/16/23, 14:37

  5. Nikita Hovratov merged patch set 2 01/16/23, 14:37