77394[TASK] Migrate low-level jQuery functions to native API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 57
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-section-container.ts+4 −5
- Build/Sources/TypeScript/backend/layout-module/paste.ts+17 −17
- Build/Sources/TypeScript/backend/ajax-data-handler.ts+4 −5
- Build/Sources/TypeScript/backend/document-save-actions.ts+2 −1
- Build/Sources/TypeScript/backend/drag-uploader.ts+13 −14
- Build/Sources/TypeScript/backend/form-engine-review.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-validation.ts+7 −7
- Build/Sources/TypeScript/backend/form-engine.ts+34 −30
- Build/Sources/TypeScript/backend/localization.ts+2 −1
- Build/Sources/TypeScript/backend/login-refresh.ts+2 −2
- Build/Sources/TypeScript/backend/module-menu.ts+2 −0
- Build/Sources/TypeScript/backend/online-media.ts+2 −1
- Build/Sources/TypeScript/backend/page-actions.ts+2 −0
- Build/Sources/TypeScript/extensionmanager/main.ts+10 −4
- Build/Sources/TypeScript/extensionmanager/repository.ts+19 −5
- Build/Sources/TypeScript/extensionmanager/update.ts+9 −17
- Build/Sources/TypeScript/install/module/environment/environment-check.ts+26 −14
- Build/Sources/TypeScript/install/module/settings/extension-configuration.ts+2 −2
- Build/Sources/TypeScript/install/module/settings/features.ts+2 −2
- Build/Sources/TypeScript/install/module/settings/presets.ts+2 −2
Show 37 more files
- Build/Sources/TypeScript/install/module/upgrade/core-update.ts+5 −13
- Build/Sources/TypeScript/install/module/upgrade/extension-scanner.ts+2 −2
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+2 −2
- Build/Sources/TypeScript/install/install.ts+2 −1
- Build/Sources/TypeScript/install/installer.ts+12 −13
- Build/Sources/TypeScript/install/message-interface.tsnew+18 −0
- Build/Sources/TypeScript/recycler/recycler.ts+5 −4
- Build/Sources/TypeScript/workspaces/backend.ts+5 −4
- Build/Sources/TypeScript/workspaces/preview.ts+2 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-section-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/layout-module/paste.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ajax-data-handler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/document-save-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-review.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/login-refresh.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/online-media.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/repository.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/update.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/environment-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/extension-configuration.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/features.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/presets.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/core-update.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-scanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/install.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/installer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/message-interface.jsnew+13 −0
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
Review log 1218
-
Andreas Kienast uploaded patch set 1 01/16/23, 15:53
-
core-ci voted on patch set 1 V -1 01/16/23, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35859
-
Andreas Kienast uploaded patch set 2
V -101/17/23, 08:03 -
core-ci voted on patch set 2 V +1 01/17/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35908
-
Andreas Kienast uploaded patch set 3
V +101/17/23, 09:35 -
core-ci voted on patch set 3 V -1 01/17/23, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35915
-
Andreas Kienast uploaded patch set 4
V -101/17/23, 10:41 -
core-ci voted on patch set 4 V -1 01/17/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35928
-
Andreas Kienast uploaded patch set 5
V -101/17/23, 11:56 -
core-ci voted on patch set 5 V +1 01/17/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35949
-
Andreas Kienast uploaded patch set 6
V +101/17/23, 13:33 -
core-ci voted on patch set 6 V +1 01/17/23, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35963
-
Oliver Hader commented on patch set 6 01/17/23, 13:51
Just a side-note: Previously closure functions have been used, by replacing iterations with `for (item of items) {}` the encapsulation of these functions is removed - thus, it might happen that variables are accidentally overridden now... -
Andreas Kienast commented on patch set 6 CR -1 01/17/23, 14:23
-1 for nowReply
Good catch, will check the patch again -
Andreas Kienast commented on patch set 6 CR 0 01/17/23, 14:35
Reply
It seems `let` encapsulates the variable into a loop so it doesn't get leaked into the outer scope. Please see https://www.typescriptlang.org/play?#code/DYUwLgBAZg9jEF4IHIwAsCWBnA+tnAhjmDAcMAJ44CuAdhgI7Ug4BuZzyA3ALABQAYxi0sMUADpgMAOYAKWDACUvPv1CQCAJ00EKAeSgBlMJoy1pWRBADayBcgA0KAEZbHLggC93yZyFoCIJrIALoqsJoQsurQcBAwUBBaOvpGJmYWihAA3vwQEEIiYiCSMvJwyvwAvvz8haISUnIKykA -
Oliver Hader commented on patch set 6 CR +1 01/17/23, 17:17
Reply
"block-level scope" for `let` is the key, thx for pointing this out -
Benni Mack voted on patch set 6 V +2 CR +2 01/19/23, 10:41
-
Benni Mack merged patch set 7 01/19/23, 10:41