Review main Merged

77394[TASK] Migrate low-level jQuery functions to native API

Andreas Kienast CR +2 V +2 Hard +256 −197 updated 01/19/23, 10:41

Commit message

This patch aims to migrate low-level helpers from jQuery to either
native browser API or TYPO3 API, where applicable without major
refactorings.

Cases handled:

* `$().ready()`
* `$.each()`
* `$.isArray()`
* `$.when()`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 57

Show 37 more files

Review log 1218

  1. Andreas Kienast uploaded patch set 1 01/16/23, 15:53

  2. core-ci voted on patch set 1 V -1 01/16/23, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35859

  3. Andreas Kienast uploaded patch set 2 V -1 01/17/23, 08:03

  4. core-ci voted on patch set 2 V +1 01/17/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35908

  5. Andreas Kienast uploaded patch set 3 V +1 01/17/23, 09:35

  6. core-ci voted on patch set 3 V -1 01/17/23, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35915

  7. Andreas Kienast uploaded patch set 4 V -1 01/17/23, 10:41

  8. core-ci voted on patch set 4 V -1 01/17/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35928

  9. Andreas Kienast uploaded patch set 5 V -1 01/17/23, 11:56

  10. core-ci voted on patch set 5 V +1 01/17/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35949

  11. Andreas Kienast uploaded patch set 6 V +1 01/17/23, 13:33

  12. core-ci voted on patch set 6 V +1 01/17/23, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35963

  13. Oliver Hader commented on patch set 6 01/17/23, 13:51

    Just a side-note: Previously closure functions have been used, by replacing iterations with `for (item of items) {}` the encapsulation of these functions is removed - thus, it might happen that variables are accidentally overridden now...
  14. Andreas Kienast commented on patch set 6 CR -1 01/17/23, 14:23

    -1 for now

    Reply

    Good catch, will check the patch again
  15. Andreas Kienast commented on patch set 6 CR 0 01/17/23, 14:35

  16. Oliver Hader commented on patch set 6 CR +1 01/17/23, 17:17

    Reply

    "block-level scope" for `let` is the key, thx for pointing this out
  17. Benni Mack voted on patch set 6 V +2 CR +2 01/19/23, 10:41

  18. Benni Mack merged patch set 7 01/19/23, 10:41