Review main Merged

77398[TASK] Render lists in submodule 'Page TSconfig' in fluid

Jasmina Ließmann CR +2 V +2 Normal +93 −56 updated 01/17/23, 10:13

Commit message

Move PageTsConfig tree rendering from a
PHP method to Fluid as a cleanup of the
controller.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 812

  1. Jasmina Ließmann uploaded patch set 1 01/16/23, 17:05

  2. core-ci voted on patch set 1 V +1 01/16/23, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35866

  3. Jasmina Ließmann uploaded patch set 2 V +1 01/16/23, 18:47

  4. core-ci voted on patch set 2 V -1 01/16/23, 19:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35874

  5. Christian Kuhn uploaded patch set 3 V -1 01/16/23, 19:37

  6. Jasmina Ließmann updated the commit message in patch set 4 01/16/23, 19:53

  7. core-ci voted on patch set 4 V -1 01/16/23, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35891

  8. core-ci voted on patch set 4 V +1 01/16/23, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35891

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 01/17/23, 09:14

  10. Oli Bartsch commented on patch set 4 CR -1 01/17/23, 10:09

    reviewing
  11. Oli Bartsch voted on patch set 4 V +2 CR +2 01/17/23, 10:13

  12. Oli Bartsch merged patch set 5 01/17/23, 10:13