Review main Merged

77399[TASK] Allow to override labels in LanguageService

Benni Mack CR +2 V +2 Hard +252 −434 updated 01/17/23, 10:55

Commit message

The functionality to handle TypoScript
overrides for Labels is now moved
from Extbase LocalizationUtility
to LanguageService.

All tests now use proper XLF files
and also real TypoScript values,
in order to make the tests easier to
understand.

Instead of magic $LOCALLANG and $LOCALLANG_UNSET
properties, LocalizationUtility now keeps
the actual LanguageService objects in its storage.

The LanguageService->overrideLabels() method should be
used with care, as other instances of the object might
not have the overrides stored.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1627

Show 2 earlier messages
  1. Benni Mack uploaded patch set 1 01/16/23, 18:09

  2. Benni Mack updated the commit message in patch set 2 01/16/23, 18:11

  1. Benni Mack updated the commit message in patch set 3 01/16/23, 18:13

  2. core-ci voted on patch set 3 V -1 01/16/23, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35870

  3. core-ci voted on patch set 2 V -1 01/16/23, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35869

  4. core-ci voted on patch set 1 V -1 01/16/23, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35868

  5. Christian Kuhn voted on patch set 3 CR -1 01/16/23, 19:06

  6. Benni Mack uploaded patch set 4 CR -1 V -1 01/16/23, 19:18

  7. core-ci voted on patch set 4 V -1 01/16/23, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35881

  8. Benni Mack uploaded patch set 5 V -1 01/16/23, 20:10

  9. core-ci voted on patch set 5 V -1 01/16/23, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35894

  10. core-ci commented on patch set 5 01/16/23, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35894

  11. Benni Mack rebased onto patch set 6 V -1 01/17/23, 08:58

  12. core-ci voted on patch set 6 V -1 01/17/23, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35909

  13. Benni Mack commented on patch set 7 V -1 01/17/23, 09:13

    Published edit on patch set 6.
  14. core-ci voted on patch set 7 V -1 01/17/23, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35912

  15. Benni Mack uploaded patch set 8 V -1 01/17/23, 09:27

  16. core-ci voted on patch set 8 V +1 01/17/23, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35913

  17. Benni Mack commented on patch set 9 V +1 01/17/23, 09:38

    Published edit on patch set 8.
  18. core-ci voted on patch set 9 V +1 01/17/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35916

  19. Anja Leichsenring voted on patch set 9 V +1 CR +1 01/17/23, 10:36

  20. Nikita Hovratov uploaded patch set 10 CR +1 V +1 01/17/23, 10:39

  21. Nikita Hovratov voted on patch set 10 V +1 CR +1 01/17/23, 10:40

  22. core-ci voted on patch set 10 V +1 01/17/23, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35926

  23. Anja Leichsenring voted on patch set 10 V +1 CR +1 01/17/23, 10:54

  24. Nikita Hovratov voted on patch set 10 V +2 CR +2 01/17/23, 10:54

  25. Nikita Hovratov merged patch set 11 01/17/23, 10:55