Review main Merged

77405[TASK] Deprecate PageRepository->where_hid_del and where_groupAccess

Benni Mack CR +2 V +2 Hard +198 −92 updated 01/18/23, 19:41

Commit message

PageRepository's public properties "where_hid_del" and "where_groupAccess"
which are used to modify a SQL query to fetch pages are now marked as protected,
thus not accessible anymore for outside usage.

Any usage will trigger a PHP deprecation notice.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1526

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 01/16/23, 19:42

  1. core-ci voted on patch set 1 V +1 01/16/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35889

  2. Benni Mack rebased onto patch set 2 V +1 01/17/23, 09:04

  3. core-ci voted on patch set 2 V +1 01/17/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35911

  4. Benni Mack uploaded patch set 3 V +1 01/17/23, 10:40

  5. core-ci voted on patch set 3 V -1 01/17/23, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35927

  6. Benni Mack commented on patch set 4 V -1 01/17/23, 12:49

    Published edit on patch set 3.
  7. core-ci voted on patch set 4 V -1 01/17/23, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35956

  8. Benni Mack uploaded patch set 5 V -1 01/17/23, 19:11

  9. core-ci voted on patch set 5 V -1 01/17/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36011

  10. Christoph Lehmann uploaded patch set 6 V -1 01/17/23, 21:10

  11. Christoph Lehmann uploaded patch set 7 01/17/23, 21:18

  12. core-ci voted on patch set 6 V -1 01/17/23, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36033

  13. core-ci voted on patch set 7 V -1 01/17/23, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36035

  14. Benni Mack uploaded patch set 8 V -1 01/17/23, 22:56

  15. core-ci voted on patch set 8 V -1 01/17/23, 23:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36048

  16. Christoph Lehmann uploaded patch set 9 V -1 01/18/23, 09:41

  17. core-ci voted on patch set 9 V -1 01/18/23, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36058

  18. Christoph Lehmann uploaded patch set 10 V -1 01/18/23, 16:13

  19. core-ci voted on patch set 10 V -1 01/18/23, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36119

  20. Christoph Lehmann uploaded patch set 11 V -1 01/18/23, 18:25

  21. core-ci voted on patch set 11 V +1 01/18/23, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36140

  22. Georg Ringer voted on patch set 11 V +1 CR +1 01/18/23, 19:28

  23. Benni Mack voted on patch set 11 V +2 CR +2 01/18/23, 19:41

  24. Benni Mack merged patch set 12 01/18/23, 19:41

  25. Benni Mack commented on patch set 12 01/18/23, 19:41

    merged as most of the work was done by CHristoph