Review main Merged

77421[TASK] Streamline usages to LanguageService

Benni Mack CR +2 V +2 Hard +131 −136 updated 01/18/23, 09:11

Commit message

This change reduces all logic where "fallback to default
language" is outside of LanguageService, allowing
LanguageService to deal with such functionality now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1218

  1. Benni Mack uploaded patch set 1 01/17/23, 14:10

  2. core-ci voted on patch set 1 V -1 01/17/23, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35966

  3. Benni Mack uploaded patch set 2 V -1 01/17/23, 17:31

  4. core-ci voted on patch set 2 V -1 01/17/23, 17:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35993

  5. Benni Mack rebased onto patch set 3 V -1 01/17/23, 20:15

  6. core-ci voted on patch set 3 V -1 01/17/23, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36021

  7. Benni Mack uploaded patch set 4 V -1 01/17/23, 20:49

  8. core-ci voted on patch set 4 V +1 01/17/23, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36026

  9. Benni Mack uploaded patch set 5 V +1 01/17/23, 21:31

  10. core-ci voted on patch set 5 V +1 01/17/23, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36036

  11. Stefan Bürk commented on patch set 5 01/17/23, 21:52

    PageRenderer.php:2436

    I guess this can be removed now.
  12. Benni Mack commented on patch set 6 V +1 01/17/23, 21:53

    Published edit on patch set 5.
  13. Benni Mack commented on patch set 6 01/17/23, 21:53

    PageRenderer.php:2436 Reply

    Done
  14. core-ci voted on patch set 6 V +1 01/17/23, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36039

  15. Stefan Bürk voted on patch set 6 CR +1 01/17/23, 22:09

  16. Stefan Bürk voted on patch set 6 V +1 01/17/23, 22:11

  17. Anja Leichsenring voted on patch set 6 V +2 CR +2 01/18/23, 09:11

  18. Anja Leichsenring merged patch set 7 01/18/23, 09:11