Review 11.5 Merged

77431[BUGFIX] Handle absolute web paths in FormEngineUtility::getIconHtml

Christian Kuhn CR +2 V +2 Easy +7 −2 updated 01/17/23, 18:06

Commit message

Since the introduction of always absolute (web) paths inside the TYPO3
backend, the TCA ctrl option `selicon_field` didn't work anymore since
relative web paths like `fileadmin/file.png` changed to
`/fileadmin/file.png`, which were not handled and resulted in a missing
icon.

This patch extends the condition for checking for absolute paths and
prevents the GU:getFileAbsFileName method from turning web paths into
empty strings.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 01/17/23, 17:47

  2. core-ci voted on patch set 1 V +1 01/17/23, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35997

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 01/17/23, 18:06

  4. Nikita Hovratov merged patch set 2 01/17/23, 18:06