Review 10.4 Merged

77457[BUGFIX] Allow CSP inline styles in directly requested SVG files

Oliver Hader CR +2 V +2 Easy +12 −4 updated 01/17/23, 21:23

Commit message

Using CSP directive `style-src 'unsafe-inline'` seems to be fine
for directly requested SVG files, since corresponding definitions
are bound to the corresponding resource. Loading styles from any
other external resource is still denied.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 01/17/23, 20:56

  2. core-ci voted on patch set 1 V +1 01/17/23, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36028

  3. Oliver Hader voted on patch set 1 V +2 CR +2 01/17/23, 21:23

  4. Oliver Hader merged patch set 2 01/17/23, 21:23