Review main Merged

77461[BUGFIX] Fix accordion visibility in image processing environment test

Benjamin Franzke CR +2 V +2 Easy +8 −8 updated 01/20/23, 10:10

Commit message

The display flex on the .modal-body was used to center the
loading animation in the modal screen but led to making
.panel-groups inaccessible. To avoid side effects we are
resetting the custom styles on .modal-body and defining the
height of .modal-loading to 100% of its parent. Since
modal-body also defines already whitespace, we are also
removing the top and bottom the margin on the first and last
element in that container, to provide a more evenly spaced
visual experience.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1316

  1. Benjamin Franzke uploaded patch set 1 01/18/23, 09:13

  2. Benjamin Franzke commented on patch set 1 01/18/23, 09:14

    Would love some feedback from Benji why overflow:hidden was added in https://review.typo3.org/c/Packages/TYPO3.CMS/+/75692
  3. core-ci voted on patch set 1 V +1 01/18/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36057

  4. Benjamin Kott commented on patch set 1 01/19/23, 13:53

    Reply

    THe overflow hidden corrects display of the shadows on rounded corners. Will check what`s the issue here is and how it can be resolved.
  5. Benjamin Kott uploaded patch set 2 V +1 01/19/23, 15:30

  6. Benjamin Kott voted on patch set 2 V +1 CR +1 01/19/23, 15:34

  7. core-ci voted on patch set 2 V +1 01/19/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36261

  8. Benjamin Franzke commented on patch set 2 V +1 CR +1 01/19/23, 15:47

    Thx! Fine by me 😊
  9. Benni Mack voted on patch set 2 V +2 CR +2 01/19/23, 16:55

  10. Benjamin Kott commented on patch set 2 CR -1 01/20/23, 08:00

    will rebase
  11. Benjamin Kott uploaded patch set 3 CR +1 V +1 01/20/23, 08:02

  12. Benjamin Kott voted on patch set 3 V +1 CR +1 01/20/23, 08:02

  13. core-ci voted on patch set 3 V +1 01/20/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36297

  14. Markus Klein voted on patch set 3 V +1 CR +1 01/20/23, 08:21

  15. Andreas Kienast voted on patch set 3 V +2 CR +2 01/20/23, 10:10

  16. Andreas Kienast merged patch set 4 01/20/23, 10:10