Review main Merged

77464[TASK] Deprecate flushByTag hook

Oli Bartsch CR +2 V +2 Easy +50 −0 updated 01/18/23, 13:47

Commit message

The hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/cache/frontend/class.t3lib_cache_frontend_abstractfrontend.php']['flushByTag']
is deprecated, since it contradicts the recommended
way for custom cache functionality, which is
to implement a custom cache frontend using
the corresponding Frontend API.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1519

  1. Oli Bartsch uploaded patch set 1 01/18/23, 10:05

  2. Oli Bartsch uploaded patch set 2 01/18/23, 10:10

  3. core-ci voted on patch set 2 V -1 01/18/23, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36064

  4. core-ci voted on patch set 1 V -1 01/18/23, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36063

  5. Oli Bartsch uploaded patch set 3 V -1 01/18/23, 10:35

  6. core-ci voted on patch set 3 V +1 01/18/23, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36067

  7. Stefan Bürk voted on patch set 3 CR +1 01/18/23, 11:56

  8. Stefan Bürk voted on patch set 3 V +1 01/18/23, 12:08

  9. Nikita Hovratov voted on patch set 3 CR +1 01/18/23, 12:36

  10. Benjamin Franzke commented on patch set 3 CR -1 01/18/23, 12:49

    Let's deprecate the Hook without providing a replacement. There are no TER extensions using this, and the API is to register a custom frontend, if you need to hook into flushed tags. (Also I like to avoid makeInstance(EventDispatcherInterface::class) whenever possible)
  11. Oli Bartsch uploaded patch set 4 CR +1 V +1 01/18/23, 13:33

  12. Oli Bartsch uploaded patch set 5 01/18/23, 13:34

  13. Benjamin Franzke voted on patch set 5 V +1 CR +1 01/18/23, 13:39

  14. Oliver Klee voted on patch set 5 CR +1 01/18/23, 13:39

  15. core-ci voted on patch set 5 V +1 01/18/23, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36096

  16. Oliver Hader voted on patch set 5 CR +1 01/18/23, 13:44

  17. Oliver Hader voted on patch set 5 V +1 01/18/23, 13:45

  18. Oli Bartsch voted on patch set 5 V +2 CR +2 01/18/23, 13:46

  19. Oli Bartsch merged patch set 6 01/18/23, 13:47