Review main Merged

77466[TASK] Migrate page title inline editor to web component

Andreas Kienast CR +2 V +2 Hard +199 −191 updated 01/19/23, 09:28

Commit message

This patch migrates the inline editor used to modify a page's table to a
standalone web component. This allows to cleanup the original
`@typo3/backend/page-actions` module and to fix state cross-dependencies
within said module.

The whole functionality is considered to be used for internal purposes
only. Therefore, the deprecated method
`\TYPO3\CMS\Backend\Template\ModuleTemplate->header()` is not adjusted, rendering a very unlikely enabled page title editing unusable.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 914

  1. Andreas Kienast uploaded patch set 1 01/18/23, 10:40

  2. Andreas Kienast uploaded patch set 2 01/18/23, 10:42

  3. Andreas Kienast uploaded patch set 3 01/18/23, 10:57

  4. core-ci voted on patch set 2 V -1 01/18/23, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36071

  5. core-ci voted on patch set 1 V -1 01/18/23, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36070

  6. core-ci voted on patch set 3 V -1 01/18/23, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36073

  7. Andreas Kienast uploaded patch set 4 V -1 01/18/23, 12:15

  8. core-ci voted on patch set 4 V +1 01/18/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36081

  9. Andreas Kienast updated the commit message in patch set 5 V +1 01/18/23, 13:47

  10. core-ci voted on patch set 5 V +1 01/18/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36098

  11. Anja Leichsenring voted on patch set 5 V +1 CR +1 01/19/23, 08:59

  12. Benni Mack voted on patch set 5 V +1 CR +1 01/19/23, 09:11

  13. Andreas Kienast voted on patch set 5 V +2 CR +2 01/19/23, 09:28

  14. Andreas Kienast merged patch set 6 01/19/23, 09:28