Review main Merged

77469[BUGFIX] Properly align switch user button when used in btn-group

Torben Hansen CR +2 V +2 Easy +9 −1 updated 01/22/23, 20:09

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Torben Hansen uploaded patch set 1 01/18/23, 12:00

  2. core-ci voted on patch set 1 V +1 01/18/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36079

  3. Andreas Kienast commented on patch set 1 01/18/23, 12:38

    I wonder if using styles within the web component wouldn't be a better solution, e.g. ``` static styles = css` :host { display: block; } ::slotted(.btn) { margin-left: -1px !important; display: initial !important; } `; ``` Yes, I dislike needing `!important` as well.
  4. Torben Hansen uploaded patch set 2 V +1 01/21/23, 09:15

  5. Torben Hansen commented on patch set 1 01/21/23, 09:19

    Reply

    I tested the suggested solution, but this leads to a flickering effect in the backend, since the component style is applied after the `backend.css` style is loaded. So I would still resolve the problem in `backend.css`.
  6. core-ci voted on patch set 2 V +1 01/21/23, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36406

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 01/22/23, 19:33

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 01/22/23, 20:09

  9. Stefan Bürk merged patch set 3 01/22/23, 20:09