77470[FEATURE] Add all countries and their localized names
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 66
- Build/Scripts/updateIsoDatabase.phpnew+199 −0
- typo3/sysext/core/Classes/Country/Country.phpnew+76 −0
- typo3/sysext/core/Classes/Country/CountryProvider.php10new+1772 −0
- typo3/sysext/core/Configuration/Services.yaml2+4 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99618-ListOfCountriesInTheWorldAndTheirLocalizedNames.rstnew+97 −0
- typo3/sysext/core/Resources/Private/Language/Iso/af.countries.xlfnew+1651 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ar.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/bg.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/bs.countries.xlfnew+1679 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ca.countries.xlfnew+1687 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ch.countries.xlfnew+91 −0
- typo3/sysext/core/Resources/Private/Language/Iso/countries.xlfnew+1273 −0
- typo3/sysext/core/Resources/Private/Language/Iso/cs.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/cy.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/da.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/de.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/el.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/eo.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/es.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/et.countries.xlfnew+1695 −0
Show 46 more files
- typo3/sysext/core/Resources/Private/Language/Iso/eu.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/fa.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/fi.countries.xlfnew+1679 −0
- typo3/sysext/core/Resources/Private/Language/Iso/fo.countries.xlfnew+563 −0
- typo3/sysext/core/Resources/Private/Language/Iso/fr.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/gl.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/he.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/hi.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/hr.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/hu.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/is.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/it.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ja.countries.xlfnew+1683 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ka.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/kl.countries.xlfnew+391 −0
- typo3/sysext/core/Resources/Private/Language/Iso/km.countries.xlfnew+1687 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ko.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/lt.countries.xlfnew+1683 −0
- typo3/sysext/core/Resources/Private/Language/Iso/lv.countries.xlfnew+1683 −0
- typo3/sysext/core/Resources/Private/Language/Iso/mi.countries.xlfnew+1211 −0
- typo3/sysext/core/Resources/Private/Language/Iso/mk.countries.xlfnew+1679 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ms.countries.xlfnew+1155 −0
- typo3/sysext/core/Resources/Private/Language/Iso/nl.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/pl.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/pt-BR.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/pt.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ro.countries.xlfnew+1687 −0
- typo3/sysext/core/Resources/Private/Language/Iso/ru.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/rw.countries.xlfnew+1631 −0
- typo3/sysext/core/Resources/Private/Language/Iso/sk.countries.xlfnew+1687 −0
- typo3/sysext/core/Resources/Private/Language/Iso/sl.countries.xlfnew+1683 −0
- typo3/sysext/core/Resources/Private/Language/Iso/sq.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/sr.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/sv.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/th.countries.xlfnew+1687 −0
- typo3/sysext/core/Resources/Private/Language/Iso/tr.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/uk.countries.xlfnew+1695 −0
- typo3/sysext/core/Resources/Private/Language/Iso/vi.countries.xlfnew+1683 −0
- typo3/sysext/core/Resources/Private/Language/Iso/zh-CN.countries.xlfnew+1691 −0
- typo3/sysext/core/Resources/Private/Language/Iso/zh-HK.countries.xlfnew+1691 −0
- typo3/sysext/core/Tests/Functional/Country/CountryTest.phpnew+47 −0
- typo3/sysext/core/Tests/Unit/Country/CountryProviderTest.phpnew+69 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Form/CountrySelectViewHelper.php5new+212 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/CountrySelectViewHelperTest.phpnew+136 −0
- composer.json+2 −0
- composer.lock+220 −1
Review log 2739
Show 914 earlier messages
-
Benni Mack uploaded patch set 1 01/18/23, 12:36
-
core-ci voted on patch set 1 V -1 01/18/23, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36086
-
Benni Mack uploaded patch set 2
V -101/18/23, 12:55 -
core-ci voted on patch set 2 V +1 01/18/23, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36089
-
Benni Mack uploaded patch set 3
V +101/18/23, 15:27 -
core-ci voted on patch set 3 V +1 01/18/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36109
-
Benni Mack uploaded patch set 4
V +101/18/23, 15:41 -
core-ci voted on patch set 4 V +1 01/18/23, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36113
-
Benni Mack uploaded patch set 5
V +101/18/23, 16:49 -
core-ci voted on patch set 5 V +1 01/18/23, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36128
-
Susi Moog commented on patch set 5 01/18/23, 17:33
-
Oliver Hader voted on patch set 5 CR +1 01/18/23, 17:35
-
Benni Mack uploaded patch set 6
CR +1V +101/18/23, 17:39 -
Susi Moog voted on patch set 6 CR +1 01/18/23, 17:43
-
core-ci voted on patch set 6 V +1 01/18/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36135
-
Georg Ringer commented on patch set 6 01/18/23, 17:55
CountryProvider.php:23is this really a database? what about "local copy of https://github url?CountryProvider.php:64getAllCountryProvider.php:69getByIsoCode2 + getByIsoCode3 as another getterCountrySelectViewHelper.php:115make it explicit. I suggest an exception with a message including all optionsCountrySelectViewHelper.php:144without testing: do we have a problem with fallbacks if no translation is available? should we return the LocalizationUtility::translate($label); then? -
Susi Moog voted on patch set 6 V +1 01/18/23, 17:56
-
Benni Mack uploaded patch set 7
CR +1V +101/18/23, 19:29 -
core-ci voted on patch set 7 V +1 01/18/23, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36143
-
Jasmina Ließmann uploaded patch set 8
V +101/18/23, 19:54 -
Jasmina Ließmann uploaded patch set 9 01/18/23, 19:58
-
core-ci voted on patch set 8 V +1 01/18/23, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36145
-
core-ci voted on patch set 9 V +1 01/18/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36146
-
Benni Mack commented on patch set 9 01/18/23, 20:49
CountryProvider.php:64ReplyDoneServices.yaml:395ReplyDoneCountrySelectViewHelper.php:115Replywill doCountrySelectViewHelper.php:144Replyadapted and covered with tests. -
Jasmina Ließmann voted on patch set 9 V +1 01/18/23, 20:52
-
Benni Mack uploaded patch set 10
V +101/18/23, 21:19 -
Benni Mack commented on patch set 10 01/18/23, 21:20
CountryProvider.php:23ReplyDoneCountryProvider.php:69ReplyDoneCountrySelectViewHelper.php:115ReplyDone -
core-ci voted on patch set 10 V +1 01/18/23, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36153
-
Oliver Hader commented on patch set 10 01/18/23, 21:41
CountryProvider.php:38Seems always to be empty... -
Stefan Bürk commented on patch set 10 01/18/23, 23:46
Nice feature, thanks for the patch. Wouldn't it be better to write the prepared country file as PHP file returning an array instead of a json file which needs to be json_decoded() in the classes ? (by the build script). That would take PHP opcode cache into account - and on updates it maybe better regonizable what have changed in the build file for review ... Just putting to discussion, maybe it has been decided already. Or I'm missing something ?CountryProvider.php:50Maybe we should use here ``` $data = json_decode(json: $content, flags: JSON_OBJECT_AS_ARRAY | JSON_THROW_ON_ERROR); ``` and either let eventual exceptions bubbles up - or catch and react on it in case decoding fails. -
Benni Mack uploaded patch set 11
V +101/19/23, 09:49 -
Benni Mack commented on patch set 11 01/19/23, 09:49
Reply
Donethanks for the input!CountryProvider.php:38ReplyDoneCountryProvider.php:50ReplyDone -
core-ci voted on patch set 11 V +1 01/19/23, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36177
-
Stefan Bürk commented on patch set 11 CR -1 01/19/23, 10:11
on it ... -
Stefan Bürk uploaded patch set 12
CR -1V +101/19/23, 10:21 -
core-ci voted on patch set 12 V +1 01/19/23, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36183
-
Stefan Bürk voted on patch set 12 V +1 CR +1 01/19/23, 11:02
-
Georg Ringer voted on patch set 12 V +2 CR +2 01/19/23, 11:12
-
Georg Ringer merged patch set 13 01/19/23, 11:12
Services.yaml:395