Review main Merged

77472[TASK] Streamline flag icons

Benjamin Kott CR +2 V +2 Nightmare +3277 −208 updated 01/20/23, 12:40

Commit message

We streamlined the flag icons and make them easier to handle.
The core provides a range of flag icons that are representing countries,
regions, movements, islands, and more. The flags are mostly used in
conjunction with languages.

We agree that a flag does not represent a language, but having a visual
identifier attached to languages makes it easier for editors to
identify the language they want to edit or translate.

New flags added in this patch will express that we understand both,
the issue and the need to differentiate languages. We chose simple
colored flags to achieve this. It still allows differentiation while
variants like de-DE and de-CH can be maintained and identified.

New flags: black, blue, cyan, green, indigo, orange, pink, purple, red,
teal, white, yellow, rainbow.

Flags of historic countries have been removed:
- AN, Netherlands Antilles (until 2010)
- CS, State Union of Serbia and Montenegro (until 2006)

Flags for language codes have been removed:
- kl, Greenlandic
- mi, Māori

Flags for country regions have been aligned:
- Spain, Catalonia: catalonia -> es-ct
- Canada, Quebec: qc -> ca-qc

Please adjust your site configuration if you are using one of
the removed or renamed flag icons.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 563

Show 543 more files

Review log 3148

Show 1523 earlier messages
  1. Benjamin Kott uploaded patch set 1 01/18/23, 13:23

  2. core-ci voted on patch set 1 V +1 01/18/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36093

  3. Benjamin Kott uploaded patch set 2 V +1 01/18/23, 14:57

  4. Benjamin Kott updated the commit message in patch set 3 01/18/23, 15:01

  5. core-ci voted on patch set 2 V +1 01/18/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36103

  6. core-ci voted on patch set 3 V +1 01/18/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36106

  7. Benjamin Kott uploaded patch set 4 V +1 01/18/23, 15:30

  8. core-ci voted on patch set 4 V -1 01/18/23, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36110

  9. Georg Ringer commented on patch set 4 01/18/23, 20:24

    wouldn't it be possible to switch to svgs? at least for the ones which are small enough in filesize?
  10. Benjamin Kott commented on patch set 4 01/18/23, 22:01

    Reply

    flags contain too much stuff, svg not possible in that size - we had that problem before.
  11. Stefan Bürk commented on patch set 4 01/18/23, 22:49

    How do we deal with removed "flags" - if instances have siteconfigs with this flags selected, they will simply stop working ("value not allowed" in the flag select). This I would say, this is kind of "breaking", falling under the core breaking policy which is "not allowed" outside x.0. At least it should be mentioned in a important rest file at minimum if ok from other / project lead. Not sure how to deal with it and how this was handled in the past. Some may have (re)-used the flags (images) in custom extensions and stuff (be/fe), butas they are part of the backend css/js I would take that as internal, and thus not covered by core breaking policy and "fine" with that.
  12. Benjamin Kott commented on patch set 4 01/19/23, 08:27

    Reply

    Hey, I am aware of this, already wrote benni yesterday about this. Noted it for now in the commit message still looking for a way to migrate this.
  13. Benjamin Kott uploaded patch set 5 V -1 01/19/23, 10:32

  14. Benjamin Kott uploaded patch set 6 01/19/23, 10:33

  15. core-ci voted on patch set 5 V -1 01/19/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36187

  16. core-ci voted on patch set 6 V -1 01/19/23, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36189

  17. Benjamin Kott uploaded patch set 7 V -1 01/19/23, 14:47

  18. Benjamin Kott commented on patch set 7 01/19/23, 14:51

    Reply

    Done
  19. Benjamin Kott commented on patch set 7 01/19/23, 14:56

    Since the squoosh/cli is no longer maintained, and it also provides almost the same and sometimes worse results for the image compressing like sharp. It was removed also in this patch. I dont think that this is necessary to mention in the commit message. https://www.npmjs.com/package/@squoosh/cli
  20. core-ci voted on patch set 7 V -1 01/19/23, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36258

  21. Benjamin Kott uploaded patch set 8 V -1 01/20/23, 10:19

  22. Andreas Kienast uploaded patch set 9 01/20/23, 10:22

  23. core-ci voted on patch set 8 V -1 01/20/23, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36318

  1. Benjamin Kott uploaded patch set 10 01/20/23, 10:33

  2. Benjamin Kott uploaded patch set 11 01/20/23, 10:35

  3. core-ci voted on patch set 9 V -1 01/20/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36320

  4. core-ci voted on patch set 11 V -1 01/20/23, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36323

  5. core-ci voted on patch set 10 V -1 01/20/23, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36322

  6. Benjamin Kott uploaded patch set 12 V -1 01/20/23, 10:46

  7. Andreas Kienast uploaded patch set 13 01/20/23, 10:48

  8. core-ci voted on patch set 12 V -1 01/20/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36324

  9. core-ci voted on patch set 13 V -1 01/20/23, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36326

  10. Benjamin Kott uploaded patch set 14 V -1 01/20/23, 11:08

  11. Benjamin Kott uploaded patch set 15 01/20/23, 11:20

  12. Andreas Kienast voted on patch set 15 V +1 CR +1 01/20/23, 11:21

  13. core-ci voted on patch set 14 V +1 01/20/23, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36334

  14. Andreas Kienast uploaded patch set 16 CR +1 V +1 01/20/23, 11:25

  15. core-ci voted on patch set 15 V +1 01/20/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36336

  16. Andreas Kienast voted on patch set 16 V +1 CR +1 01/20/23, 11:35

  17. core-ci voted on patch set 16 V +1 01/20/23, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36338

  18. Anja Leichsenring voted on patch set 16 V +1 CR +1 01/20/23, 11:50

  19. Stefan Bürk commented on patch set 16 CR -1 01/20/23, 11:58

    Gruntfile.js:936

    readded duplicated comment, like below ?
  20. Stefan Bürk commented on patch set 17 CR +1 V +1 01/20/23, 12:00

    Published edit on patch set 16.
  21. Stefan Bürk voted on patch set 17 V +1 CR +1 01/20/23, 12:01

  22. Stefan Bürk commented on patch set 17 01/20/23, 12:01

    Gruntfile.js:936 Reply

    Done
  23. core-ci voted on patch set 17 V +1 01/20/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36343

  24. Andreas Kienast voted on patch set 17 V +2 CR +2 01/20/23, 12:40

  25. Andreas Kienast merged patch set 18 01/20/23, 12:40