Review main Merged

77476[FEATURE] Add password policy action to exclude validators in SU mode

Torben Hansen CR +2 V +2 Easy +37 −1 updated 03/22/23, 21:22

Commit message

The new password policy action `UPDATE_USER_PASSWORD_SWITCH_USER_MODE`
has been added in order to allow exclusion of a password policy
validator, if the current user is in switch user mode.

Additionally, the new password policy action is now used in the
global default password policy for the `NotCurrentPasswordValidator`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1216

  1. Torben Hansen uploaded patch set 1 01/18/23, 14:59

  2. core-ci voted on patch set 1 V +1 01/18/23, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36104

  3. Oli Bartsch commented on patch set 1 CR -1 01/18/23, 15:20

    is in switch

    Feature-99608-AddPasswordPolicyActionToExcludeValidatorsInSUMode.rst:1

    Actually we always try to make the rst a bit less technical. Currently the RST completely duplicates the commit message. Could this please be improved?
  4. Torben Hansen uploaded patch set 2 CR -1 V +1 01/18/23, 15:39

  5. Torben Hansen commented on patch set 2 01/18/23, 15:41

    Reply

    Done

    Feature-99608-AddPasswordPolicyActionToExcludeValidatorsInSUMode.rst:1 Reply

    I improved the "Impact" section of the RST to be less technical.
  6. Torben Hansen rebased onto patch set 3 02/07/23, 18:19

  7. core-ci voted on patch set 3 V -1 02/07/23, 18:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37305

  8. Benni Mack commented on patch set 4 V -1 02/08/23, 07:51

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 02/08/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37331

  10. Torben Hansen rebased onto patch set 5 V +1 03/09/23, 11:49

  11. core-ci voted on patch set 5 V +1 03/09/23, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38696

  12. Benni Mack voted on patch set 5 CR +1 03/15/23, 16:22

  13. Georg Ringer voted on patch set 5 V +1 CR +1 03/16/23, 06:56

  14. Markus Klein voted on patch set 5 CR +1 03/16/23, 09:52

  15. Benni Mack voted on patch set 5 V +2 CR +2 03/22/23, 21:22

  16. Benni Mack merged patch set 6 03/22/23, 21:22