77481[TASK] Add search field to active 'Page TSconfig'
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/utility/collapse-state-persister.ts+14 −2
- Build/Sources/TypeScript/backend/page-tsconfig.tsnew+161 −0
- Build/types/TYPO3/index.d.ts+1 −0
- Build/Gruntfile.js+18 −1
- Build/package-lock.json+6 −0
- Build/package.json+1 −0
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+37 −103
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+0 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+0 −1
- typo3/sysext/backend/Configuration/Backend/Modules.php+8 −5
- typo3/sysext/backend/Configuration/JavaScriptModules.php+7 −1
- typo3/sysext/backend/Resources/Private/Partials/PageTsConfig/Tree.html+10 −7
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+42 −31
- typo3/sysext/backend/Resources/Public/JavaScript/Contrib/mark.jsnew+12 −0
- typo3/sysext/backend/Resources/Public/JavaScript/utility/collapse-state-persister.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-tsconfig.jsnew+13 −0
Review log 2131
Show 46 earlier messages
-
Jasmina Ließmann uploaded patch set 1 01/18/23, 17:42
-
core-ci voted on patch set 1 V -1 01/18/23, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36136
-
Andreas Kienast commented on patch set 1 CR -1 01/19/23, 07:56
on it -
Andreas Kienast uploaded patch set 2
CR -1V -101/19/23, 14:30 -
core-ci voted on patch set 2 V -1 01/19/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36255
-
Andreas Kienast uploaded patch set 3
V -101/19/23, 14:52
-
core-ci voted on patch set 3 V +1 01/19/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36260
-
Georg Ringer commented on patch set 3 01/19/23, 15:14
would make a feature out of it. users love features -
Christian Kuhn commented on patch set 3 01/19/23, 16:27
Reply
we will have a rather general .rst for the current TS + pageTS module works soon which will document this. -
Georg Ringer commented on patch set 3 V -1 01/20/23, 06:36
- only works in mode "all", therefore must only be shown in this module - is case sensitive but IMO shouldn't - if something found, this should be highlighted -
Andreas Kienast commented on patch set 3 01/20/23, 07:05
Reply
* Will be made case-insensitive * We decided to not implement highlighting for now, this is tedious work when manipulating DOM on-the-fly. -
Andreas Kienast uploaded patch set 4
V +101/20/23, 08:52 -
core-ci voted on patch set 4 V +1 01/20/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36301
-
Andreas Kienast uploaded patch set 5
V +101/20/23, 09:17 -
Andreas Kienast commented on patch set 5 01/20/23, 09:19
I decided to implement marking via mark.js. The original idea was to toggle the visibility of non-matching sub-trees which turned out to be more complex than estimated. -
core-ci voted on patch set 5 V +1 01/20/23, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36305
-
Christian Kuhn commented on patch set 5 CR -1 01/20/23, 11:05
not finished here, but close. -1 for the time being. -
Christian Kuhn uploaded patch set 6
CR -1V +101/24/23, 10:03 -
Christian Kuhn commented on patch set 6 01/24/23, 10:04
rebased for now. -
core-ci voted on patch set 6 V +1 01/24/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36527
-
Christian Kuhn uploaded patch set 7
V +101/24/23, 12:12 -
core-ci voted on patch set 7 V +1 01/24/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36532
-
Andreas Kienast uploaded patch set 8
V +101/24/23, 13:24 -
Andreas Kienast uploaded patch set 9 01/24/23, 13:29
-
core-ci voted on patch set 8 V +1 01/24/23, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36535
-
Christian Kuhn updated the commit message in patch set 10 01/24/23, 13:37
-
core-ci voted on patch set 9 V +1 01/24/23, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36536
-
core-ci voted on patch set 10 V +1 01/24/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36539
-
Christian Kuhn voted on patch set 10 V +1 CR +1 01/24/23, 13:51
-
Andreas Kienast voted on patch set 10 V +2 CR +2 01/24/23, 13:51
-
Andreas Kienast merged patch set 11 01/24/23, 13:51