Review main Merged

77481[TASK] Add search field to active 'Page TSconfig'

Jasmina Ließmann CR +2 V +2 Hard +331 −153 updated 01/24/23, 13:51

Commit message

The "Page TSconfig" backend module now has a search that
allows an integrator to search PageTS either by a settings
identifier (e.g. "mod.linkval") or a value (e.g. "textpic").

Partial searches are also supported, "wizardItems" resolves
to "mod.wizards.newContentElement.wizardItems".

The search value is stored in the browser session and retained
when the module is visited again. To avoid conflicts with the
internal `collapse-state-persister` module, a new setting is
introduced to disable the modules recovery behavior if a
specific key is available in localStorage or sessionStorage.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 2131

Show 46 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 01/18/23, 17:42

  2. core-ci voted on patch set 1 V -1 01/18/23, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36136

  3. Andreas Kienast commented on patch set 1 CR -1 01/19/23, 07:56

    on it
  4. Andreas Kienast uploaded patch set 2 CR -1 V -1 01/19/23, 14:30

  5. core-ci voted on patch set 2 V -1 01/19/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36255

  6. Andreas Kienast uploaded patch set 3 V -1 01/19/23, 14:52

  1. core-ci voted on patch set 3 V +1 01/19/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36260

  2. Georg Ringer commented on patch set 3 01/19/23, 15:14

    would make a feature out of it. users love features
  3. Christian Kuhn commented on patch set 3 01/19/23, 16:27

    Reply

    we will have a rather general .rst for the current TS + pageTS module works soon which will document this.
  4. Georg Ringer commented on patch set 3 V -1 01/20/23, 06:36

    - only works in mode "all", therefore must only be shown in this module - is case sensitive but IMO shouldn't - if something found, this should be highlighted
  5. Andreas Kienast commented on patch set 3 01/20/23, 07:05

    Reply

    * Will be made case-insensitive * We decided to not implement highlighting for now, this is tedious work when manipulating DOM on-the-fly.
  6. Andreas Kienast uploaded patch set 4 V +1 01/20/23, 08:52

  7. core-ci voted on patch set 4 V +1 01/20/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36301

  8. Andreas Kienast uploaded patch set 5 V +1 01/20/23, 09:17

  9. Andreas Kienast commented on patch set 5 01/20/23, 09:19

    I decided to implement marking via mark.js. The original idea was to toggle the visibility of non-matching sub-trees which turned out to be more complex than estimated.
  10. core-ci voted on patch set 5 V +1 01/20/23, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36305

  11. Christian Kuhn commented on patch set 5 CR -1 01/20/23, 11:05

    not finished here, but close. -1 for the time being.
  12. Christian Kuhn uploaded patch set 6 CR -1 V +1 01/24/23, 10:03

  13. Christian Kuhn commented on patch set 6 01/24/23, 10:04

    rebased for now.
  14. core-ci voted on patch set 6 V +1 01/24/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36527

  15. Christian Kuhn uploaded patch set 7 V +1 01/24/23, 12:12

  16. core-ci voted on patch set 7 V +1 01/24/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36532

  17. Andreas Kienast uploaded patch set 8 V +1 01/24/23, 13:24

  18. Andreas Kienast uploaded patch set 9 01/24/23, 13:29

  19. core-ci voted on patch set 8 V +1 01/24/23, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36535

  20. Christian Kuhn updated the commit message in patch set 10 01/24/23, 13:37

  21. core-ci voted on patch set 9 V +1 01/24/23, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36536

  22. core-ci voted on patch set 10 V +1 01/24/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36539

  23. Christian Kuhn voted on patch set 10 V +1 CR +1 01/24/23, 13:51

  24. Andreas Kienast voted on patch set 10 V +2 CR +2 01/24/23, 13:51

  25. Andreas Kienast merged patch set 11 01/24/23, 13:51