77484[TASK] Reduce SQL queries in AbstractMenuContentObject::isSubMenu()
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1924
-
Christoph Lehmann uploaded patch set 1 01/18/23, 20:51
-
core-ci voted on patch set 1 V -1 01/18/23, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36150
-
Oliver Hader commented on patch set 1 01/18/23, 22:06
-
Stefan Bürk commented on patch set 1 01/18/23, 22:29
AbstractMenuContentObject.php:1403Can't we reuse the already available "runtime" cache instead of introducing a "instance" property as cache here ? Maybe some thoughts about proper identifier must be put in, but guess that's cleaner. What do you think ? -
Christoph Lehmann commented on patch set 1 01/18/23, 23:16
AbstractMenuContentObject.php:1403ReplyGood idea. Currently there is one issue left, so that tests fail. I think the isSubMenuCache needs the "current" pid. Will check tomorrow. -
Christoph Lehmann commented on patch set 1 01/18/23, 23:18
AbstractMenuContentObject.php:1403Reply(in the cache identifier) -
Christoph Lehmann uploaded patch set 2
V -101/19/23, 09:49 -
core-ci voted on patch set 2 V -1 01/19/23, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36178
-
Christoph Lehmann commented on patch set 2 01/19/23, 10:45
AbstractMenuContentObject.php:1407ReplyDone -
Christoph Lehmann commented on patch set 2 01/19/23, 10:46
AbstractMenuContentObject.php:1403ReplyDone -
Christoph Lehmann uploaded patch set 3
V -101/19/23, 10:59 -
Christoph Lehmann commented on patch set 3 01/19/23, 11:01
Added list of page ids to cache identifier, because a second subpage menu of the same site may has a different records in $this->menuArr -
Stefan Bürk commented on patch set 3 01/19/23, 11:16
AbstractMenuContentObject.php:184This is now superflous and can be removed. -
core-ci voted on patch set 3 V -1 01/19/23, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36195
-
Oliver Klee commented on patch set 3 01/19/23, 11:37
AbstractMenuContentObject.php:1407Please let's make the check explicit instead of relying on an implicit bool cast: if (!is_array($cachePagesNextLevel)) { -
Christoph Lehmann uploaded patch set 4
V -101/20/23, 09:23 -
Christian Kuhn commented on patch set 4 01/20/23, 09:27
AbstractMenuContentObject.php:1407ReplyDone -
core-ci voted on patch set 4 V -1 01/20/23, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36308
-
Christian Kuhn uploaded patch set 5
V -101/20/23, 10:03 -
Christian Kuhn commented on patch set 5 01/20/23, 10:04
Removed v11 *for now*: I think it's good to have this in main for a while and wait a bit. If this works out, it may be ok to backport to v11.AbstractMenuContentObject.php:184ReplyDone -
core-ci voted on patch set 5 V +1 01/20/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36315
-
Christian Kuhn voted on patch set 5 V +1 CR +1 01/20/23, 10:38
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 01/20/23, 11:05
-
Anja Leichsenring merged patch set 6 01/20/23, 11:06
AbstractMenuContentObject.php:1407