Review main Merged

77485[FEATURE] Introduce event to prevent downloading of language packs

Kevin Appelt CR +2 V +2 Normal +192 −47 updated 01/20/23, 11:46

Commit message

With the newly introduced event, it is possible to ignore extensions or
individual language packs for extensions when downloading the language
packs.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 3038

Show 813 earlier messages
  1. Kevin Appelt uploaded patch set 1 01/18/23, 21:05

  2. core-ci voted on patch set 1 V -1 01/18/23, 21:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36151

  3. core-ci commented on patch set 1 01/18/23, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36151

  4. core-ci commented on patch set 1 01/18/23, 23:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36151

  5. Kevin Appelt commented on patch set 1 CR -1 01/18/23, 23:58

    on it
  6. Stefan Bürk uploaded patch set 2 CR -1 V -1 01/19/23, 00:23

  7. Stefan Bürk commented on patch set 2 01/19/23, 00:25

    Reply

    Saw the on it after pushing :/
  8. core-ci voted on patch set 2 V +1 01/19/23, 00:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36162

  9. Stefan Bürk commented on patch set 2 01/19/23, 00:41

    LanguagePackCommand.php:119

    $extension['key'] can be simplefied by using ```php foreach($extensions as $extensionKey => $extension) { ... } ``` due the return of `$languagePackService->getExtensionLanguagePackDetails()` now returns the extension key as array key.

    LanguagePackCommand.php:143

    Missing switch case for newly introduced return value `skipped` ....

    LanguagePackService.php:219

    `skipped` is a newly introduced state. Should be mentioned in @return docblock as possible return value. Consumer must be checked, at least the `intall/module/maintenance/language-packs.ts` needs to be extended to handle the new `skipped` type properly.
  10. Stefan Bürk voted on patch set 2 CR -1 01/19/23, 00:42

  11. Kevin Appelt uploaded patch set 3 CR -1 V +1 01/19/23, 12:30

  12. Kevin Appelt commented on patch set 3 01/19/23, 12:32

    Should be ready for review now :)

    LanguagePackCommand.php:119 Reply

    Done

    LanguagePackCommand.php:143 Reply

    Done

    LanguagePackService.php:219 Reply

    Done
  13. core-ci voted on patch set 3 V +1 01/19/23, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36231

  1. Markus Klein commented on patch set 3 01/19/23, 14:18

    Feature-98394-IntroduceEventToPreventDownloadingOfLanguagePacks.rst:36

    do we need this function here?
  2. Markus Klein commented on patch set 3 01/19/23, 14:38

    MaintenanceController.php:596

    reusing the variable name is a bit hard to read here.

    MaintenanceController.php:603

    array_values again?
  3. Markus Klein commented on patch set 3 01/19/23, 14:41

    LanguagePackService.php:218

    if (!isset($extensions[$key]['packs'][$iso]))
  4. Nikita Hovratov uploaded patch set 4 V +1 01/19/23, 16:16

  5. Nikita Hovratov commented on patch set 4 01/19/23, 16:17

    Feature-98394-IntroduceEventToPreventDownloadingOfLanguagePacks.rst:36 Reply

    Done

    MaintenanceController.php:596 Reply

    Done

    MaintenanceController.php:603 Reply

    Done

    LanguagePackService.php:218 Reply

    Done
  6. core-ci voted on patch set 4 V +1 01/19/23, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36271

  7. Markus Klein voted on patch set 4 CR +1 01/19/23, 18:21

  8. Stefan Bürk commented on patch set 4 CR -1 01/19/23, 22:13

    backend display if an iso is deactivated leaves missing table colum, which looks nasty ... and if it not the last one, but inbetween the download button for extension iso is not under the colum for the corresponding iso ... meaning that it "moves" left .. which is not good either .. on it
  9. Stefan Bürk commented on patch set 4 01/19/23, 22:46

    LanguagePackCommand.php:137

    We should iterate here `$isos` instead. Otherwise the "skipped" handling would be superflous. I think it's better to loop them and proper display the skipped of a extension language pack download instead of silently ignoring it (if `--no-progress` is selected.
  10. Stefan Bürk uploaded patch set 5 CR +1 V +1 01/19/23, 22:46

  11. Stefan Bürk commented on patch set 5 01/19/23, 22:47

    Reply

    Done

    LanguagePackCommand.php:137 Reply

    Done
  12. Stefan Bürk commented on patch set 5 V +1 CR +1 01/19/23, 22:50

    nice one - I think last edges are polished now. Thanks for the work on that.
  13. core-ci voted on patch set 5 V +1 01/19/23, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36286

  14. Markus Klein voted on patch set 5 CR +1 01/20/23, 07:15

  15. Markus Klein commented on patch set 5 01/20/23, 07:47

    ModifyLanguagePacksEvent.php:44

    I'm thinking about these exceptions here: Do we really need/want them? We can safely unset() something that isn't there, so why bother an ext author with exceptions. It doesn't cause harm if I try to exclude something which isn't there anyways. Opinions?
  16. Jörg Bösche voted on patch set 5 CR +1 01/20/23, 08:01

  17. Stefan Bürk commented on patch set 5 V 0 CR 0 01/20/23, 08:36

    ModifyLanguagePacksEvent.php:44 Reply

    Your thinking here are right. Not really needed to guard and throw exceptions here. Silent ignorung not set stuff is okay here.
  18. Stefan Bürk commented on patch set 5 CR -1 01/20/23, 09:03

    on it ...
  19. Stefan Bürk uploaded patch set 6 CR +1 V +1 01/20/23, 09:04

  20. Stefan Bürk commented on patch set 6 V +1 CR +1 01/20/23, 09:04

    ModifyLanguagePacksEvent.php:44 Reply

    Done
  21. core-ci voted on patch set 6 V +1 01/20/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36302

  22. Christian Kuhn voted on patch set 6 V +2 CR +2 01/20/23, 11:12

  23. Christian Kuhn merged patch set 7 01/20/23, 11:12

  24. Christian Kuhn commented on patch set 7 01/20/23, 11:14

    note we *usually* add tests to events, but skipped it in this special case: This patch took *way* too long already, works, and will most likely never break again.
  25. Markus Klein commented on patch set 7 V +1 CR +1 01/20/23, 11:46

    thanks