77485[FEATURE] Introduce event to prevent downloading of language packs
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/install/module/maintenance/language-packs.ts+40 −21
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-98394-IntroduceEventToPreventDownloadingOfLanguagePacks.rst2new+59 −0
- typo3/sysext/install/Classes/Command/LanguagePackCommand.php6+30 −13
- typo3/sysext/install/Classes/Controller/MaintenanceController.php4+5 −1
- typo3/sysext/install/Classes/Service/Event/ModifyLanguagePacksEvent.php3new+43 −0
- typo3/sysext/install/Classes/Service/LanguagePackService.php4+14 −11
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/language-packs.js+1 −1
Review log 3038
Show 813 earlier messages
-
Kevin Appelt uploaded patch set 1 01/18/23, 21:05
-
core-ci voted on patch set 1 V -1 01/18/23, 21:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36151
-
core-ci commented on patch set 1 01/18/23, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36151
-
core-ci commented on patch set 1 01/18/23, 23:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36151
-
Kevin Appelt commented on patch set 1 CR -1 01/18/23, 23:58
on it -
Stefan Bürk uploaded patch set 2
CR -1V -101/19/23, 00:23 -
Stefan Bürk commented on patch set 2 01/19/23, 00:25
Reply
Saw the on it after pushing :/ -
core-ci voted on patch set 2 V +1 01/19/23, 00:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36162
-
Stefan Bürk commented on patch set 2 01/19/23, 00:41
LanguagePackCommand.php:119$extension['key'] can be simplefied by using ```php foreach($extensions as $extensionKey => $extension) { ... } ``` due the return of `$languagePackService->getExtensionLanguagePackDetails()` now returns the extension key as array key.LanguagePackCommand.php:143Missing switch case for newly introduced return value `skipped` ....LanguagePackService.php:219`skipped` is a newly introduced state. Should be mentioned in @return docblock as possible return value. Consumer must be checked, at least the `intall/module/maintenance/language-packs.ts` needs to be extended to handle the new `skipped` type properly. -
Stefan Bürk voted on patch set 2 CR -1 01/19/23, 00:42
-
Kevin Appelt uploaded patch set 3
CR -1V +101/19/23, 12:30 -
Kevin Appelt commented on patch set 3 01/19/23, 12:32
Should be ready for review now :)LanguagePackCommand.php:119ReplyDoneLanguagePackCommand.php:143ReplyDoneLanguagePackService.php:219ReplyDone -
core-ci voted on patch set 3 V +1 01/19/23, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36231
-
Markus Klein commented on patch set 3 01/19/23, 14:18
Feature-98394-IntroduceEventToPreventDownloadingOfLanguagePacks.rst:36do we need this function here? -
Markus Klein commented on patch set 3 01/19/23, 14:38
MaintenanceController.php:596reusing the variable name is a bit hard to read here.MaintenanceController.php:603array_values again? -
Markus Klein commented on patch set 3 01/19/23, 14:41
LanguagePackService.php:218if (!isset($extensions[$key]['packs'][$iso])) -
Nikita Hovratov uploaded patch set 4
V +101/19/23, 16:16 -
Nikita Hovratov commented on patch set 4 01/19/23, 16:17
Feature-98394-IntroduceEventToPreventDownloadingOfLanguagePacks.rst:36ReplyDoneMaintenanceController.php:596ReplyDoneMaintenanceController.php:603ReplyDoneLanguagePackService.php:218ReplyDone -
core-ci voted on patch set 4 V +1 01/19/23, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36271
-
Markus Klein voted on patch set 4 CR +1 01/19/23, 18:21
-
Stefan Bürk commented on patch set 4 CR -1 01/19/23, 22:13
backend display if an iso is deactivated leaves missing table colum, which looks nasty ... and if it not the last one, but inbetween the download button for extension iso is not under the colum for the corresponding iso ... meaning that it "moves" left .. which is not good either .. on it -
Stefan Bürk commented on patch set 4 01/19/23, 22:46
LanguagePackCommand.php:137We should iterate here `$isos` instead. Otherwise the "skipped" handling would be superflous. I think it's better to loop them and proper display the skipped of a extension language pack download instead of silently ignoring it (if `--no-progress` is selected. -
Stefan Bürk uploaded patch set 5
CR +1V +101/19/23, 22:46 -
Stefan Bürk commented on patch set 5 01/19/23, 22:47
Reply
DoneLanguagePackCommand.php:137ReplyDone -
Stefan Bürk commented on patch set 5 V +1 CR +1 01/19/23, 22:50
nice one - I think last edges are polished now. Thanks for the work on that. -
core-ci voted on patch set 5 V +1 01/19/23, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36286
-
Markus Klein voted on patch set 5 CR +1 01/20/23, 07:15
-
Markus Klein commented on patch set 5 01/20/23, 07:47
ModifyLanguagePacksEvent.php:44I'm thinking about these exceptions here: Do we really need/want them? We can safely unset() something that isn't there, so why bother an ext author with exceptions. It doesn't cause harm if I try to exclude something which isn't there anyways. Opinions? -
Jörg Bösche voted on patch set 5 CR +1 01/20/23, 08:01
-
Stefan Bürk commented on patch set 5 V 0 CR 0 01/20/23, 08:36
ModifyLanguagePacksEvent.php:44ReplyYour thinking here are right. Not really needed to guard and throw exceptions here. Silent ignorung not set stuff is okay here. -
Stefan Bürk commented on patch set 5 CR -1 01/20/23, 09:03
on it ... -
Stefan Bürk uploaded patch set 6
CR +1V +101/20/23, 09:04 -
Stefan Bürk commented on patch set 6 V +1 CR +1 01/20/23, 09:04
ModifyLanguagePacksEvent.php:44ReplyDone -
core-ci voted on patch set 6 V +1 01/20/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36302
-
Christian Kuhn voted on patch set 6 V +2 CR +2 01/20/23, 11:12
-
Christian Kuhn merged patch set 7 01/20/23, 11:12
-
Christian Kuhn commented on patch set 7 01/20/23, 11:14
note we *usually* add tests to events, but skipped it in this special case: This patch took *way* too long already, works, and will most likely never break again. -
Markus Klein commented on patch set 7 V +1 CR +1 01/20/23, 11:46
thanks