77487[FEATURE] Show site configurations (YAML) in configuration module
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99626-SitesConfigurationYAMLInConfigurationModule.rst2new+27 −0
- typo3/sysext/core/Tests/Acceptance/Application/ConfigurationModule/ConfigurationModuleProviderCest.php+2 −1
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SitesTcaConfiguration.php2renamed+2 −5
- typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/SitesYamlConfiguration.php2copied+7 −7
- typo3/sysext/lowlevel/Configuration/Services.yaml+16 −7
- typo3/sysext/lowlevel/Documentation/BackendModules/Configuration.rst+2 −1
- typo3/sysext/lowlevel/Resources/Private/Language/locallang.xlf2+5 −2
Review log 2230
Show 45 earlier messages
-
Eric Chavaillaz uploaded patch set 1 01/19/23, 08:11
-
core-ci voted on patch set 1 V +1 01/19/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36169
-
Anja Leichsenring commented on patch set 1 V +1 CR +1 01/19/23, 08:38
nice one! -
Oli Bartsch commented on patch set 1 CR -1 01/19/23, 09:21
Feature-99626-SitesConfigurationYAMLInConfigurationModule.rst:14Usually we describe what has been added and why. Currently, only the previous state is explained here, which therefore does not describe the implemented feature. Could this please be improved? Additionally, please try to use proper line breaks. See other RST files for reference.SitesConfigurationProvider.php:27We could use constructor property promotion hereSitesConfigurationProvider.php:35We could skip this variable.locallang.xlf:32Great patch. Let's just improve the naming here. My suggesting: - Sites: TCA configuration - Sites: YAML configuration Also the language identifiers should be harmonized. Suggestion: - sitesTcaConfiguration - sitesYamlConfiguration and the same for the service identifiers (Services.yaml) -
Eric Chavaillaz uploaded patch set 2
CR +1V +101/19/23, 10:23
-
Eric Chavaillaz uploaded patch set 3 01/19/23, 10:26
-
Eric Chavaillaz commented on patch set 3 01/19/23, 10:39
Thanks Oliver, I agree with all your comments.Feature-99626-SitesConfigurationYAMLInConfigurationModule.rst:14ReplyDoneSitesConfigurationProvider.php:27ReplyDoneSitesConfigurationProvider.php:35ReplyDonelocallang.xlf:32ReplyThanks Oliver, I agree with all your comments. -
core-ci voted on patch set 2 V -1 01/19/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36184
-
core-ci voted on patch set 3 V -1 01/19/23, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36185
-
Eric Chavaillaz commented on patch set 3 01/19/23, 13:49
I don't see why this error occur... -
core-ci commented on patch set 3 01/20/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36185
-
Eric Chavaillaz uploaded patch set 4
V -101/20/23, 10:55 -
Oli Bartsch commented on patch set 4 01/20/23, 11:01
Reply
I assume it's because of this array https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Tests/Acceptance/Application/ConfigurationModule/ConfigurationModuleProviderCest.php#L82, which needs to be adjusted. -
core-ci voted on patch set 4 V +1 01/20/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36330
-
Oli Bartsch commented on patch set 4 01/20/23, 16:42
Reply
DonePatch looks fine and works. Please let's only add some more information to the commit message. -
Eric Chavaillaz updated the commit message in patch set 5
V +101/21/23, 06:36 -
core-ci voted on patch set 5 V +1 01/21/23, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36405
-
Oli Bartsch updated the commit message in patch set 6
V +101/23/23, 11:29 -
Oli Bartsch commented on patch set 6 V +1 CR +1 01/23/23, 11:30
Reply
Done -
core-ci voted on patch set 6 V +1 01/23/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36461
-
Stefan Bürk commented on patch set 6 01/23/23, 12:10
SitesTcaConfiguration.php:25Would go with `protected readonly` here ...SitesYamlConfiguration.php:25Would go with `protected readonly` here ... -
Oli Bartsch uploaded patch set 7
CR +1V +101/23/23, 12:14 -
Oli Bartsch commented on patch set 7 V +1 CR +1 01/23/23, 12:14
SitesTcaConfiguration.php:25ReplyDoneSitesYamlConfiguration.php:25ReplyDone -
core-ci voted on patch set 7 V +1 01/23/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36463
-
Stefan Bürk voted on patch set 7 V +2 CR +2 01/23/23, 12:24
-
Stefan Bürk merged patch set 8 01/23/23, 12:24
-
Oliver Hader commented on patch set 8 01/23/23, 15:04
What about having something similar to `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][ConfigurationController::class]['modifyBlindedConfigurationOptions']` in `GlobalVariableProvider`? Currently this shows "internal" details of YAML site configs... -
Torben Hansen commented on patch set 8 01/23/23, 15:10
Reply
Yes, we definitely need "something" to make it possible to hide defined configuration keys. -
Eric Chavaillaz commented on patch set 8 01/24/23, 11:17
Reply
Yes, thanks, I have adapt it.Do you think about a "generic" solution or a based module solution? Because for the site configurations, I think from scratch nothing is really internal, no? -
Eric Chavaillaz commented on patch set 8 01/25/23, 08:58
I create a new issue : https://forge.typo3.org/issues/99713