Review main Merged

77487[FEATURE] Show site configurations (YAML) in configuration module

Eric Chavaillaz CR +2 V +2 Normal +61 −23 updated 01/25/23, 08:58

Commit message

This adds a new entry to the configuration module, displaying
the YAML configuration of all available site configurations.

To properly differentiate between the new entry and the already
existing site configuration related entry, which displays site configurations' TCA configuration is the naming aligned.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2230

Show 45 earlier messages
  1. Eric Chavaillaz uploaded patch set 1 01/19/23, 08:11

  2. core-ci voted on patch set 1 V +1 01/19/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36169

  3. Anja Leichsenring commented on patch set 1 V +1 CR +1 01/19/23, 08:38

    nice one!
  4. Oli Bartsch commented on patch set 1 CR -1 01/19/23, 09:21

    Feature-99626-SitesConfigurationYAMLInConfigurationModule.rst:14

    Usually we describe what has been added and why. Currently, only the previous state is explained here, which therefore does not describe the implemented feature. Could this please be improved? Additionally, please try to use proper line breaks. See other RST files for reference.

    SitesConfigurationProvider.php:27

    We could use constructor property promotion here

    SitesConfigurationProvider.php:35

    We could skip this variable.

    locallang.xlf:32

    Great patch. Let's just improve the naming here. My suggesting: - Sites: TCA configuration - Sites: YAML configuration Also the language identifiers should be harmonized. Suggestion: - sitesTcaConfiguration - sitesYamlConfiguration and the same for the service identifiers (Services.yaml)
  5. Eric Chavaillaz uploaded patch set 2 CR +1 V +1 01/19/23, 10:23

  1. Eric Chavaillaz uploaded patch set 3 01/19/23, 10:26

  2. Eric Chavaillaz commented on patch set 3 01/19/23, 10:39

    Thanks Oliver, I agree with all your comments.

    Feature-99626-SitesConfigurationYAMLInConfigurationModule.rst:14 Reply

    Done

    SitesConfigurationProvider.php:27 Reply

    Done

    SitesConfigurationProvider.php:35 Reply

    Done

    locallang.xlf:32 Reply

    Thanks Oliver, I agree with all your comments.
  3. core-ci voted on patch set 2 V -1 01/19/23, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36184

  4. core-ci voted on patch set 3 V -1 01/19/23, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36185

  5. Eric Chavaillaz commented on patch set 3 01/19/23, 13:49

    I don't see why this error occur...
  6. core-ci commented on patch set 3 01/20/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36185

  7. Eric Chavaillaz uploaded patch set 4 V -1 01/20/23, 10:55

  8. Oli Bartsch commented on patch set 4 01/20/23, 11:01

  9. core-ci voted on patch set 4 V +1 01/20/23, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36330

  10. Oli Bartsch commented on patch set 4 01/20/23, 16:42

    Reply

    Done
    Patch looks fine and works. Please let's only add some more information to the commit message.
  11. Eric Chavaillaz updated the commit message in patch set 5 V +1 01/21/23, 06:36

  12. core-ci voted on patch set 5 V +1 01/21/23, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36405

  13. Oli Bartsch updated the commit message in patch set 6 V +1 01/23/23, 11:29

  14. Oli Bartsch commented on patch set 6 V +1 CR +1 01/23/23, 11:30

    Reply

    Done
  15. core-ci voted on patch set 6 V +1 01/23/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36461

  16. Stefan Bürk commented on patch set 6 01/23/23, 12:10

    SitesTcaConfiguration.php:25

    Would go with `protected readonly` here ...

    SitesYamlConfiguration.php:25

    Would go with `protected readonly` here ...
  17. Oli Bartsch uploaded patch set 7 CR +1 V +1 01/23/23, 12:14

  18. Oli Bartsch commented on patch set 7 V +1 CR +1 01/23/23, 12:14

    SitesTcaConfiguration.php:25 Reply

    Done

    SitesYamlConfiguration.php:25 Reply

    Done
  19. core-ci voted on patch set 7 V +1 01/23/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36463

  20. Stefan Bürk voted on patch set 7 V +2 CR +2 01/23/23, 12:24

  21. Stefan Bürk merged patch set 8 01/23/23, 12:24

  22. Oliver Hader commented on patch set 8 01/23/23, 15:04

    What about having something similar to `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][ConfigurationController::class]['modifyBlindedConfigurationOptions']` in `GlobalVariableProvider`? Currently this shows "internal" details of YAML site configs...
  23. Torben Hansen commented on patch set 8 01/23/23, 15:10

    Reply

    Yes, we definitely need "something" to make it possible to hide defined configuration keys.
  24. Eric Chavaillaz commented on patch set 8 01/24/23, 11:17

    Reply

    Yes, thanks, I have adapt it.
    Do you think about a "generic" solution or a based module solution? Because for the site configurations, I think from scratch nothing is really internal, no?
  25. Eric Chavaillaz commented on patch set 8 01/25/23, 08:58