Review main Merged

77489[TASK] Deprecate GeneralUtility::_POST()

Anja Leichsenring CR +2 V +2 Normal +106 −15 updated 01/19/23, 17:20

Commit message

As PSR-7 is favored since a long time, all usages to
this legacy method are removed, and it is finally
deprecated (will be removed in TYPO3 v13.0)

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1320

  1. Anja Leichsenring uploaded patch set 1 01/19/23, 09:56

  2. core-ci voted on patch set 1 V -1 01/19/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36179

  3. Anja Leichsenring uploaded patch set 2 V -1 01/19/23, 10:57

  4. core-ci voted on patch set 2 V -1 01/19/23, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36194

  5. Anja Leichsenring uploaded patch set 3 V -1 01/19/23, 11:12

  6. Anja Leichsenring uploaded patch set 4 01/19/23, 11:26

  7. core-ci voted on patch set 3 V +1 01/19/23, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36199

  8. Anja Leichsenring uploaded patch set 5 01/19/23, 11:31

  9. Stefan Bürk commented on patch set 5 01/19/23, 11:40

    ServerRequestFactory.php:86

    I would say we do not need to replicate that backwards compat from GU here. $request->withParsedBody() type hingts (also not natively) with `@param array|object|null $data`, so having a string is not good at all here. The combat has been needed only if `GU::_POST()` has been called with a parameter idententfier not set in the $_POST array (which is always an array). If called without parameter, `$_POST` array has been return (empty or with data). This combat is superflous here. The combat equialant would be: ```php $getParam = GeneralUtillity::_POST('someparameter'); // short, not fully guarded - just makeing the point $getParam = $_POST['someparameter'] ?? ''; ``` And the check in L90 *may* be tightend to properly check for allowed types anyway (also not really in this change scope), but not an issue I would say - without the compat lines, this should be null or an array anyway.
  10. core-ci voted on patch set 5 V +1 01/19/23, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36209

  11. Anja Leichsenring uploaded patch set 6 V +1 01/19/23, 12:24

  12. Anja Leichsenring commented on patch set 6 01/19/23, 12:35

    ServerRequestFactory.php:86 Reply

    Done
  13. core-ci voted on patch set 6 V +1 01/19/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36229

  14. Benni Mack updated the commit message in patch set 7 V +1 01/19/23, 16:14

  15. core-ci voted on patch set 7 V +1 01/19/23, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36270

  16. Benni Mack commented on patch set 8 V +1 01/19/23, 16:47

    Published edit on patch set 7.
  17. Benni Mack voted on patch set 8 V +1 CR +1 01/19/23, 16:49

  18. core-ci voted on patch set 8 V +1 01/19/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36277

  19. Christian Kuhn voted on patch set 8 V +2 CR +2 01/19/23, 17:20

  20. Christian Kuhn merged patch set 9 01/19/23, 17:20