77490[WIP][TASK] Replace getEnv() with $_ENV in all places
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 19
- Build/phpunit/UnitTestsBootstrap.php+4 −4
- typo3/sysext/backend/Classes/Command/CreateBackendUserCommand.php+1 −1
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/EnvVariableProcessor.php+1 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+10 −5
- typo3/sysext/core/Classes/TypoScript/AST/AbstractAstBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Extension/ApplicationEnvironment.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Extension/InstallMysqlCoreEnvironment.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Support/Extension/InstallPostgresqlCoreEnvironment.php+5 −5
- typo3/sysext/core/Tests/Functional/Cache/Backend/MemcachedBackendTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php+5 −5
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+3 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/install/Classes/Command/SetupCommand.php+1 −1
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+6 −1
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerSetupCheckController.php+3 −2
- composer.json+1 −1
- composer.lock+7 −8
Review log 1019
-
TYPO3com uploaded patch set 1 01/19/23, 10:02
-
core-ci voted on patch set 1 V -1 01/19/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36180
-
- Thiel uploaded patch set 2
V -101/19/23, 16:13 -
core-ci voted on patch set 2 V -1 01/19/23, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36269
-
Benni Mack rebased onto patch set 3
V -103/08/23, 08:11 -
core-ci voted on patch set 3 V -1 03/08/23, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38643
-
Benni Mack rebased onto patch set 4
V -103/24/23, 08:24 -
core-ci voted on patch set 4 V -1 03/24/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39525
-
Benni Mack uploaded patch set 5
V -103/24/23, 10:03 -
Benni Mack updated the commit message in patch set 6 03/24/23, 10:04
-
core-ci voted on patch set 5 V -1 03/24/23, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39533
-
core-ci voted on patch set 6 V -1 03/24/23, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39535
-
Stefan Bürk commented on patch set 6 03/24/23, 11:09
I guess there are places missing: * Build/phpunit/UnitTestsBootstrap.php * TF has quite some putenv() / getenv() calls * ... -
Stefan Bürk uploaded patch set 7
V -104/15/23, 17:01 -
core-ci voted on patch set 7 V -1 04/15/23, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40685
-
Stefan Bürk uploaded patch set 8
V -104/15/23, 18:10 -
core-ci voted on patch set 8 V -1 04/15/23, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40693
-
Christian Kuhn commented on patch set 8 01/22/24, 12:20
Hey. I'm going to abandon here for now, I hope its ok to do so. The main issue is that $_ENV is *not* typically populated in various environments, so switching from getEnv() to direct global $_ENV access is not ok and breaks a lot. *If* we want to avoid getEnv(), this will need an API instead. -
Christian Kuhn abandoned the change 01/22/24, 12:20