77491[FEATURE] Introduce PHP attribute RemoteEvent (webhook)
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Hader +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Hader +1
Issues 2
Files 2
Review log 1215
-
Frank Nägler uploaded patch set 1 01/19/23, 10:06
-
core-ci voted on patch set 1 V +1 01/19/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36181
-
Oli Bartsch commented on patch set 1 01/19/23, 10:19
RemoteEvent.php:31Just curious if we might need an $identifier as well?Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17I suggest to omit "we" here. Actually, I would be fine with omitting the whole sentence, since it more or less just duplicates the first paragraph.Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17to beFeature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:20This sentence does IMO only suite in the commit message since the changelog file might be read when webhooks are already available.Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:21Is this relevant for integrators? -
Frank Nägler commented on patch set 1 01/19/23, 10:25
RemoteEvent.php:31Replyidentifier is the class name -
Frank Nägler commented on patch set 1 01/19/23, 10:29
RemoteEvent.php:28ReplyAckFeature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17ReplyAckFeature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17ReplyAckFeature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:20ReplyAckFeature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:21ReplyAck -
Frank Nägler uploaded patch set 2
V +101/19/23, 10:29 -
Oli Bartsch commented on patch set 2 01/19/23, 10:36
RemoteEvent.php:31ReplyAck -
Oli Bartsch voted on patch set 2 V +1 CR +1 01/19/23, 10:36
-
core-ci voted on patch set 2 V +1 01/19/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36186
-
Oliver Hader commented on patch set 2 01/19/23, 11:52
RemoteEvent.php:28Parameter in one line?RemoteEvent.php:38If not required, we could possibly omit changing the description... -
Oliver Hader commented on patch set 3
CR +1V +101/19/23, 11:54Published edit on patch set 2. -
Oliver Hader voted on patch set 3 V +1 CR +1 01/19/23, 12:19
-
Oli Bartsch commented on patch set 3 V +2 CR +2 01/19/23, 12:38
RemoteEvent.php:28ReplyDoneRemoteEvent.php:38ReplyDone -
Oli Bartsch merged patch set 4 01/19/23, 12:38
-
core-ci voted on patch set 3 V +1 01/19/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36216
RemoteEvent.php:28