Review main Merged

77491[FEATURE] Introduce PHP attribute RemoteEvent (webhook)

Frank Nägler CR +2 V +2 Normal +75 −0 updated 01/19/23, 12:43

Commit message

To allow tagging an event as a remote event (aka webhook), we
introduce a new PHP attribute, `RemoteEvent` to mark and
configure events for the usage as webhook.

This is required for the upcoming webhook functionality.
The attribute must be part of EXT:core to prevent
dependency issues.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1

Issues 2

Files 2

Review log 1215

  1. Frank Nägler uploaded patch set 1 01/19/23, 10:06

  2. core-ci voted on patch set 1 V +1 01/19/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36181

  3. Oli Bartsch commented on patch set 1 01/19/23, 10:19

    RemoteEvent.php:28

    Let's introduce this const when needed (in the actual webhook implementation patch).

    RemoteEvent.php:31

    Just curious if we might need an $identifier as well?

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17

    I suggest to omit "we" here. Actually, I would be fine with omitting the whole sentence, since it more or less just duplicates the first paragraph.

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17

    to be

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:20

    This sentence does IMO only suite in the commit message since the changelog file might be read when webhooks are already available.

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:21

    Is this relevant for integrators?
  4. Frank Nägler commented on patch set 1 01/19/23, 10:25

    RemoteEvent.php:31 Reply

    identifier is the class name
  5. Frank Nägler commented on patch set 1 01/19/23, 10:29

    RemoteEvent.php:28 Reply

    Ack

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17 Reply

    Ack

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:17 Reply

    Ack

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:20 Reply

    Ack

    Feature-99632-IntroducePHPAttributeToMarkAnEventAsRemoteEventWebhook.rst:21 Reply

    Ack
  6. Frank Nägler uploaded patch set 2 V +1 01/19/23, 10:29

  7. Oli Bartsch commented on patch set 2 01/19/23, 10:36

    RemoteEvent.php:31 Reply

    Ack
  8. Oli Bartsch voted on patch set 2 V +1 CR +1 01/19/23, 10:36

  9. core-ci voted on patch set 2 V +1 01/19/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36186

  10. Oliver Hader commented on patch set 2 01/19/23, 11:52

    RemoteEvent.php:28

    Parameter in one line?

    RemoteEvent.php:38

    If not required, we could possibly omit changing the description...
  11. Oliver Hader commented on patch set 3 CR +1 V +1 01/19/23, 11:54

    Published edit on patch set 2.
  12. Oliver Hader voted on patch set 3 V +1 CR +1 01/19/23, 12:19

  13. Oli Bartsch commented on patch set 3 V +2 CR +2 01/19/23, 12:38

    RemoteEvent.php:28 Reply

    Done

    RemoteEvent.php:38 Reply

    Done
  14. Oli Bartsch merged patch set 4 01/19/23, 12:38

  15. core-ci voted on patch set 3 V +1 01/19/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36216