77493[TASK] Reduce usages of GU::_GP()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/ElementBrowser/DatabaseBrowser.php+1 −1
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+1 −1
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php8+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageInfoViewHelper.php2+8 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php2+8 −1
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+1 −1
Review log 3245
Show 1320 earlier messages
-
Anja Leichsenring uploaded patch set 1 01/19/23, 10:47
-
core-ci voted on patch set 1 V -1 01/19/23, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36190
-
Anja Leichsenring uploaded patch set 2
V -101/19/23, 11:10 -
Anja Leichsenring uploaded patch set 3 01/19/23, 11:24
-
core-ci voted on patch set 2 V -1 01/19/23, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36198
-
Stefan Bürk commented on patch set 3 01/19/23, 12:04
PagePathViewHelper.php:59see PageInfoViewHelper -
Anja Leichsenring uploaded patch set 4 01/19/23, 12:07
-
core-ci voted on patch set 3 V -1 01/19/23, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36204
-
Anja Leichsenring uploaded patch set 5 01/19/23, 12:20
-
Anja Leichsenring commented on patch set 5 01/19/23, 12:21
PageInfoViewHelper.php:60ReplyDonePagePathViewHelper.php:59ReplyDone -
core-ci voted on patch set 5 V -1 01/19/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36227
-
Anja Leichsenring uploaded patch set 6
V -101/19/23, 13:24 -
Anja Leichsenring uploaded patch set 7 01/19/23, 13:45
-
core-ci voted on patch set 6 V -1 01/19/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36245
-
core-ci voted on patch set 7 V +1 01/19/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36249
-
Stefan Bürk updated the commit message in patch set 8
V +101/19/23, 23:57 -
core-ci voted on patch set 8 V +1 01/20/23, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36289
-
Stefan Bürk voted on patch set 8 V +1 CR +1 01/20/23, 00:06
-
Georg Ringer commented on patch set 8 CR -1 01/20/23, 06:16
DatabaseRecordList.php:2128This is a breaking change, please use a new Argument -
Stefan Bürk commented on patch set 8 01/20/23, 08:17
DatabaseRecordList.php:2128ReplyHad the same thought as you first. The class is marked as internal, thus breaking is non-breaking.
-
Anja Leichsenring commented on patch set 8 01/20/23, 09:20
DatabaseRecordList.php:2128Replyexactly, not breaking due to internal class. -
Anja Leichsenring updated the commit message in patch set 9
CR +1V +101/20/23, 09:31 -
Anja Leichsenring updated the commit message in patch set 10 01/20/23, 09:31
-
Jörg Bösche voted on patch set 10 CR +1 01/20/23, 09:37
-
core-ci voted on patch set 9 V +1 01/20/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36311
-
core-ci voted on patch set 10 V +1 01/20/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36312
-
Georg Ringer commented on patch set 10 01/20/23, 10:08
DatabaseRecordList.php:2128ReplyI know but we can in this case still choose to make the life easier or harder ... -
Benni Mack commented on patch set 10 01/20/23, 10:33
DatabaseRecordList.php:2128Replyfor the sake of getting rid of GP(), I would not do it. I would rather like to streamline the class to be similar to the FileList class, and use a SearchDemand object just as in FileList and get rid of all other parameters as well (so, basically let's use a new method ->generate(?SearchDemand $searchDemand) and deprecate start - but that's another topic. That's why I would not include the whole DatabaseRecordList part in this change - my 2 cents. -
Stefan Bürk commented on patch set 10 01/20/23, 10:37
DatabaseRecordList.php:2128Replyhaving a "required" argument after optional arguemnts does not help to ease it anyway - as named arguemtn calling would not be possible vor a v11/v12 compat mode as v11 does support PHP7.4 without named argument support ... and having it optional would not help either. So extensions using `internal` stuff on `own risk` still needs to provide version depending switched code, if it is in the middle or at the end ... -
Anja Leichsenring commented on patch set 10 01/20/23, 10:45
DatabaseRecordList.php:2128ReplyI will revert the change to the start() method. The other hunk should be safe. -
Anja Leichsenring uploaded patch set 11
CR +1V +101/20/23, 10:47 -
Anja Leichsenring uploaded patch set 12 01/20/23, 10:48
-
Anja Leichsenring uploaded patch set 13 01/20/23, 10:50
-
Anja Leichsenring uploaded patch set 14 01/20/23, 11:15
-
Anja Leichsenring commented on patch set 14 01/20/23, 11:16
DatabaseRecordList.php:2128ReplyDone -
core-ci voted on patch set 13 V -1 01/20/23, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36329
-
Anja Leichsenring uploaded patch set 15 01/20/23, 11:24
-
Anja Leichsenring uploaded patch set 16 01/20/23, 11:28
-
core-ci voted on patch set 15 V -1 01/20/23, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36337
-
core-ci voted on patch set 14 V -1 01/20/23, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36335
-
core-ci voted on patch set 16 V +1 01/20/23, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36339
-
Christian Kuhn voted on patch set 16 V +1 CR +1 01/20/23, 12:34
-
Stefan Bürk voted on patch set 16 V +1 CR +1 01/20/23, 12:46
-
Christian Kuhn voted on patch set 16 V +2 CR +2 01/20/23, 12:53
-
Christian Kuhn merged patch set 17 01/20/23, 12:53
PageInfoViewHelper.php:60