Review main Merged

77499[TASK] Optimize Iso database updater code

Benni Mack CR +2 V +2 Hard +478 −455 updated 01/19/23, 12:50

Commit message

This change restructures some code
within the new updateIsoDatabase.php importer
to keep proper sorting in label files,
which was uncoordinated before.

That's why the countries.xlf (english),
is now updated.

Code for further ISO imports are
prepared to reduce code duplication.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 01/19/23, 12:09

  2. Benni Mack updated the commit message in patch set 2 01/19/23, 12:11

  3. core-ci voted on patch set 2 V +1 01/19/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36223

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 01/19/23, 12:43

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 01/19/23, 12:50

  6. Christian Kuhn merged patch set 3 01/19/23, 12:50