Review main Merged

77503[TASK] Use official translations for ISO 639-1/2 languages

Benni Mack CR +2 V +2 Impossible +93353 −1074 updated 04/19/23, 11:10

Commit message

Previously, TYPO3 manually had lists of
labels for languages (primarily used to
select a user's language for the TYPO3 Backend
interface).

Similar to the Country API, the list
of official languages are now fetched
from a debian repository, which provides
a list of official language keys and
their labels so translators do not need
to update this static list, and developers
do not need to add a label when a new language
is added.

A list of two-letter code language keys
in addition to three-letter code language keys
are now available and can slowly be used
to be supported instead of the TYPO3 core list.

Previous "pseudo-classes" such as IsoCodeService
and their respective XLF files are removed.

Code in be_users.lang itemsProcFunc and
SetupModuleController can then be simplified.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 64

Show 44 more files

Review log 1521

  1. Benni Mack uploaded patch set 1 01/19/23, 13:25

  2. Benni Mack uploaded patch set 2 01/19/23, 13:36

  3. core-ci voted on patch set 2 V +1 01/19/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36247

  4. core-ci voted on patch set 1 V -1 01/19/23, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36246

  5. Georg Ringer commented on patch set 2 01/19/23, 14:02

    OfficialLanguages.php:23

    language data
  6. Benni Mack commented on patch set 3 V +1 01/19/23, 17:03

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 01/19/23, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36283

  8. Benni Mack marked it work in progress 03/24/23, 11:44

  9. Markus Klein commented on patch set 3 03/29/23, 14:47

    I'm on it
  10. Markus Klein uploaded patch set 4 V +1 04/04/23, 23:07

  11. Markus Klein commented on patch set 4 04/04/23, 23:08

    Reply

    Done

    OfficialLanguages.php:23 Reply

    Done
  12. Markus Klein uploaded patch set 5 04/04/23, 23:10

  13. core-ci voted on patch set 4 V +1 04/04/23, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40135

  14. core-ci voted on patch set 5 V +1 04/04/23, 23:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40136

  15. Benni Mack uploaded patch set 6 V +1 04/18/23, 14:03

  16. Benni Mack marked it ready for review 04/18/23, 14:03

  17. core-ci voted on patch set 6 V +1 04/18/23, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40877

  18. Markus Klein voted on patch set 6 V +1 CR +1 04/18/23, 15:43

  19. Georg Ringer voted on patch set 6 V +1 CR +1 04/18/23, 18:29

  20. Benni Mack voted on patch set 6 V +2 CR +2 04/19/23, 11:10

  21. Benni Mack merged patch set 7 04/19/23, 11:10