Review main Merged

77506[TASK] Improve display of "TypoScript Records" submodule

Jasmina Ließmann CR +2 V +2 Normal +90 −90 updated 01/21/23, 11:57

Commit message

Remove a superfluous table column that indicated if the
record was not marked as "Root".
Display multiple TypoScript records in the same table
column according to the page they are stored on.
Add info box if no TypoScript record was found in the
system at all.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1729

Show 34 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 01/19/23, 15:35

  2. core-ci voted on patch set 1 V -1 01/19/23, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36262

  3. Jasmina Ließmann rebased onto patch set 2 V -1 01/19/23, 17:03

  4. Christian Kuhn commented on patch set 2 V -1 01/19/23, 17:09

    missing rows if there is a rootline with a leaf page having a record, but a page in tree has no record.
  1. core-ci voted on patch set 1 V -1 01/19/23, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36262

  2. core-ci voted on patch set 2 V +1 01/19/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36282

  3. Jasmina Ließmann uploaded patch set 3 V +1 01/20/23, 09:22

  4. Jasmina Ließmann commented on patch set 3 01/20/23, 09:22

    Reply

    Done
  5. Jasmina Ließmann uploaded patch set 4 01/20/23, 09:30

  6. Jasmina Ließmann uploaded patch set 5 01/20/23, 09:36

  7. core-ci voted on patch set 3 V +1 01/20/23, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36307

  8. core-ci voted on patch set 4 V +1 01/20/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36310

  9. core-ci voted on patch set 5 V -1 01/20/23, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36313

  10. Jasmina Ließmann uploaded patch set 6 V -1 01/20/23, 14:01

  11. Jasmina Ließmann uploaded patch set 7 01/20/23, 14:08

  12. Jasmina Ließmann updated the commit message in patch set 8 01/20/23, 14:11

  13. core-ci voted on patch set 8 V +1 01/20/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36367

  14. core-ci voted on patch set 6 V +1 01/20/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36363

  15. core-ci voted on patch set 7 V -1 01/20/23, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36366

  16. core-ci voted on patch set 7 V +1 01/20/23, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36366

  17. Jasmina Ließmann uploaded patch set 9 V +1 01/20/23, 21:03

  18. Stefan Bürk commented on patch set 9 01/20/23, 21:04

    locallang.xlf:76

    casing -> `TypoScript`
  19. core-ci voted on patch set 9 V +1 01/20/23, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36388

  20. Christian Kuhn uploaded patch set 10 V +1 01/20/23, 21:18

  21. Christian Kuhn commented on patch set 9 01/20/23, 21:18

    locallang.xlf:76 Reply

    Done
  22. core-ci voted on patch set 10 V +1 01/20/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36389

  23. Stefan Bürk voted on patch set 10 V +1 CR +1 01/20/23, 21:31

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 01/21/23, 11:57

  25. Christian Kuhn merged patch set 11 01/21/23, 11:57