Review main Merged

77508[TASK] Define explicit routes for Extbase Backend Modules

Benni Mack CR +2 V +2 Normal +190 −10 updated 01/25/23, 09:29

Commit message

Previously, the controller / action pairs of an Extbase Backend
Module were defined via corresponding GET parameters. Thanks to
the new Module Registration API and the support for individual
sub routes, it's now also possible to define explicit routes
for each controller / action pair. This is done automatically,
as long as the "enableNamespacedArgumentsForBackend" feature
toggle is turned off, which is the default.

This therefore results in following change:

http://example.com/typo3/module/system/BeuserTxBeuser?controller=BackendUser&action=filemounts

becomes

http://example.com/typo3/module/system/BeuserTxBeuser/BackendUser/filemounts

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 1626

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 01/19/23, 15:56

  1. core-ci voted on patch set 1 V -1 01/19/23, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36265

  2. Benni Mack uploaded patch set 2 V -1 01/23/23, 14:24

  3. core-ci voted on patch set 2 V -1 01/23/23, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36473

  4. Oli Bartsch uploaded patch set 3 V -1 01/24/23, 11:56

  5. Oli Bartsch uploaded patch set 4 01/24/23, 12:05

  6. core-ci voted on patch set 3 V -1 01/24/23, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36530

  7. core-ci voted on patch set 4 V -1 01/24/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36531

  8. Oli Bartsch rebased onto patch set 5 V -1 01/24/23, 13:20

  9. core-ci voted on patch set 5 V -1 01/24/23, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36534

  10. Oli Bartsch uploaded patch set 6 V -1 01/24/23, 15:11

  11. core-ci voted on patch set 6 V +1 01/24/23, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36561

  12. Oli Bartsch uploaded patch set 7 V +1 01/24/23, 16:28

  13. core-ci voted on patch set 7 V +1 01/24/23, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36565

  14. Oli Bartsch updated the commit message in patch set 8 V +1 01/24/23, 16:38

  15. core-ci voted on patch set 8 V +1 01/24/23, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36566

  16. Oli Bartsch uploaded patch set 9 V +1 01/24/23, 21:21

  17. core-ci voted on patch set 9 V +1 01/24/23, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36582

  18. Christian Kuhn commented on patch set 9 01/24/23, 23:56

    Feature-99647-SpecificRoutesForBackendModules.rst:116

    all controller / action combinations are explicitly ...
  19. Oli Bartsch commented on patch set 10 V +1 01/25/23, 07:41

    Published edit on patch set 9.
  20. Oli Bartsch commented on patch set 10 01/25/23, 07:41

    Feature-99647-SpecificRoutesForBackendModules.rst:116 Reply

    Done
  21. core-ci voted on patch set 10 V +1 01/25/23, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36597

  22. Benni Mack voted on patch set 10 V +1 CR +1 01/25/23, 08:48

  23. Stefan Bürk commented on patch set 10 V +1 CR +1 01/25/23, 09:10

    nice one
  24. Oli Bartsch voted on patch set 10 V +2 CR +2 01/25/23, 09:29

  25. Oli Bartsch merged patch set 11 01/25/23, 09:29