Review main Merged

77510[TASK] Remove jQuery from `@typo3/backend/page-actions`

Andreas Kienast CR +2 V +2 Normal +54 −45 updated 01/26/23, 13:44

Commit message

This patch removes jQuery from the `@typo3/backend/page-actions` module
used in the Page module to hide "hidden" content elements completely.

Since jQuery's sliding was used which has no native API,
`requestAnimationFrame()` is used to achieve the same behavior.

To have a fluent CSS-based animation, positioning of `.t3-page-ce` needs
to be fixed, making futher adjustments necessary.

Additionally, an unused class is removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1319

  1. Andreas Kienast uploaded patch set 1 01/19/23, 16:31

  2. Andreas Kienast uploaded patch set 2 01/19/23, 16:31

  3. core-ci voted on patch set 1 V -1 01/19/23, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36273

  4. core-ci voted on patch set 2 V -1 01/19/23, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36274

  5. Andreas Kienast uploaded patch set 3 V -1 01/25/23, 10:50

  6. core-ci voted on patch set 3 V -1 01/25/23, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36604

  7. Andreas Kienast uploaded patch set 4 V -1 01/25/23, 11:54

  8. core-ci voted on patch set 4 V +1 01/25/23, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36610

  9. Andreas Kienast commented on patch set 4 V -1 01/25/23, 12:02

    Hiding elements not fluent anymore _pulls hair_
  10. Andreas Kienast uploaded patch set 5 V +1 01/25/23, 12:13

  11. core-ci voted on patch set 5 V +1 01/25/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36611

  12. Oli Bartsch commented on patch set 5 01/25/23, 16:51

    page-actions.ts:54

    scrollHeight
  13. Oli Bartsch uploaded patch set 6 V +1 01/25/23, 21:01

  14. Oli Bartsch commented on patch set 6 V +1 CR +1 01/25/23, 21:02

    page-actions.ts:54 Reply

    Done
  15. core-ci voted on patch set 6 V +1 01/25/23, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36627

  16. Andreas Kienast commented on patch set 6 01/26/23, 07:17

    page-actions.ts:54 Reply

    Thanks!
  17. Benni Mack voted on patch set 6 V +1 CR +1 01/26/23, 13:31

  18. Andreas Kienast voted on patch set 6 V +2 CR +2 01/26/23, 13:44

  19. Andreas Kienast merged patch set 7 01/26/23, 13:44