77512[TASK] Unify wording when speaking about TypoScript records and files
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 33
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Site/SiteModuleCest.php+9 −9
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+31 −31
- typo3/sysext/felogin/Documentation/UsersManual/Index.rst+1 −1
- typo3/sysext/felogin/Resources/Private/Language/locallang.xlf+1 −1
- typo3/sysext/fluid_styled_content/Documentation/Configuration/ConstantEditor/Index.rst+5 −5
- typo3/sysext/fluid_styled_content/Documentation/Configuration/TypoScript/Index.rst+2 −2
- typo3/sysext/fluid_styled_content/Documentation/FirstSteps/DefaultTemplate.rst+16 −17
- typo3/sysext/fluid_styled_content/Documentation/Images/AutomaticScreenshots/TypoScript/ConstantEditor.rst.txt4+1 −1
- typo3/sysext/fluid_styled_content/Documentation/Images/AutomaticScreenshots/TypoScript/EditTemplateRecord.rst.txt+1 −1
- typo3/sysext/fluid_styled_content/Documentation/Images/AutomaticScreenshots/TypoScript/IncludeTypoScriptTemplate.rst.txt+1 −1
- typo3/sysext/fluid_styled_content/Documentation/Installation/Index.rst+1 −1
- typo3/sysext/fluid_styled_content/Documentation/Introduction/Index.rst+1 −1
- typo3/sysext/fluid_styled_content/Documentation/screenshots.json+10 −10
- typo3/sysext/form/Documentation/I/Concepts/Configuration/Index.rst+1 −1
- typo3/sysext/form/Documentation/QuickStartForIntegrators/Index.rst+4 −4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageAccessFailureReasons.php+1 −1
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+24 −25
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+2 −2
Show 13 more files
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+2 −2
- typo3/sysext/indexed_search/Documentation/Configuration/TypoScript/Index.rst+1 −1
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_mod.xlf+1 −1
- typo3/sysext/install/Classes/Service/SetupService.php+2 −2
- typo3/sysext/rte_ckeditor/Documentation/Configuration/Concepts.rst+2 −2
- typo3/sysext/tstemplate/Resources/Private/Language/locallang.xlf+13 −22
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_ceditor.xlf+2 −2
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_info.xlf+3 −3
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_mod.xlf+1 −1
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_objbrowser.xlf+6 −6
- typo3/sysext/tstemplate/composer.json+1 −1
- typo3/sysext/tstemplate/ext_emconf.php+2 −2
- typo3/sysext/tstemplate/README.rst+1 −1
Review log 1418
-
Jasmina Ließmann uploaded patch set 1 01/19/23, 16:50
-
core-ci voted on patch set 1 V +1 01/19/23, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36278
-
Stefan Bürk commented on patch set 2
V +101/19/23, 22:57Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 01/19/23, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36287
-
Stefan Bürk commented on patch set 2 01/19/23, 23:06
Nice one, and thank you for the whole streamlining and unify work you are doing.ConstantEditor.rst.txt:9I'm not sure about some "TypoScript file" .. specially where "Static TypoScript" defitions/files are loaded. Not sure, if we should still differentiate here, as including a TypoScript file with ex. `@include` in a TypoScript file is something slighty different than the "static TypoScript File include" ... what do you think ? Other places too. -
Jasmina Ließmann commented on patch set 2 01/20/23, 09:47
ConstantEditor.rst.txt:9ReplyYes, I'm a little unsure too. I had at least one distinction in mind between TypoScript datasets that can be created in the backend (= "records") and TypoScript files that are located within extensions (static templates, everything with .typoscript, etc.)(= "files"), so that it is clear which type of source/storage location is meant. I'd also like to rename the record type "Template" ("sys_template") to "TypoScript record", but somehow that's double-dubbed as well. -
Jasmina Ließmann uploaded patch set 3
V +101/20/23, 10:21 -
Jasmina Ließmann commented on patch set 3 01/20/23, 10:23
Reply
Thank you! :) -
Jasmina Ließmann commented on patch set 3 01/20/23, 10:31
ConstantEditor.rst.txt:9ReplyOn it -
core-ci voted on patch set 3 V +1 01/20/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36319
-
Jasmina Ließmann voted on patch set 3 V -1 01/20/23, 11:05
-
Jasmina Ließmann voted on patch set 3 V 0 CR -1 01/20/23, 11:05
-
Jasmina Ließmann uploaded patch set 4
CR -1V +101/20/23, 12:18 -
core-ci voted on patch set 4 V +1 01/20/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36344
-
Jasmina Ließmann commented on patch set 4 01/20/23, 12:36
ConstantEditor.rst.txt:9ReplyDone -
Christian Kuhn voted on patch set 4 V +1 CR +1 01/20/23, 13:02
-
Stefan Bürk voted on patch set 4 V +2 CR +2 01/20/23, 13:05
-
Stefan Bürk merged patch set 5 01/20/23, 13:05