Review main Merged

77512[TASK] Unify wording when speaking about TypoScript records and files

Jasmina Ließmann CR +2 V +2 Hard +151 −162 updated 01/20/23, 13:05

Commit message

Rename the record type "Template" to "TypoScript record"
("sys_template"). Use a unified wording for TypoScript records by
renaming words like "TypoScript template" and "TypoScript template
records" to "TypoScript record".

Clarify what "Static TypoScript files" are by introducing the name
"TypoScript set". TypoScript sets are a collection of TypoScript
files, which are located and maintained in extensions. Respectivly
renaming terms like "Static TypoScript files" and "Static templates"
to "TypoScript set".

Improve the wording at the initial setup of a TypoScript record when
using the options "Constant Editor" or "Override TypoScript" of the
module "TypoScript".

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 33

Show 13 more files

Review log 1418

  1. Jasmina Ließmann uploaded patch set 1 01/19/23, 16:50

  2. core-ci voted on patch set 1 V +1 01/19/23, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36278

  3. Stefan Bürk commented on patch set 2 V +1 01/19/23, 22:57

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 01/19/23, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36287

  5. Stefan Bürk commented on patch set 2 01/19/23, 23:06

    Nice one, and thank you for the whole streamlining and unify work you are doing.

    ConstantEditor.rst.txt:9

    I'm not sure about some "TypoScript file" .. specially where "Static TypoScript" defitions/files are loaded. Not sure, if we should still differentiate here, as including a TypoScript file with ex. `@include` in a TypoScript file is something slighty different than the "static TypoScript File include" ... what do you think ? Other places too.
  6. Jasmina Ließmann commented on patch set 2 01/20/23, 09:47

    ConstantEditor.rst.txt:9 Reply

    Yes, I'm a little unsure too. I had at least one distinction in mind between TypoScript datasets that can be created in the backend (= "records") and TypoScript files that are located within extensions (static templates, everything with .typoscript, etc.)(= "files"), so that it is clear which type of source/storage location is meant. I'd also like to rename the record type "Template" ("sys_template") to "TypoScript record", but somehow that's double-dubbed as well.
  7. Jasmina Ließmann uploaded patch set 3 V +1 01/20/23, 10:21

  8. Jasmina Ließmann commented on patch set 3 01/20/23, 10:23

    Reply

    Thank you! :)
  9. Jasmina Ließmann commented on patch set 3 01/20/23, 10:31

    ConstantEditor.rst.txt:9 Reply

    On it
  10. core-ci voted on patch set 3 V +1 01/20/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36319

  11. Jasmina Ließmann voted on patch set 3 V -1 01/20/23, 11:05

  12. Jasmina Ließmann voted on patch set 3 V 0 CR -1 01/20/23, 11:05

  13. Jasmina Ließmann uploaded patch set 4 CR -1 V +1 01/20/23, 12:18

  14. core-ci voted on patch set 4 V +1 01/20/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36344

  15. Jasmina Ließmann commented on patch set 4 01/20/23, 12:36

    ConstantEditor.rst.txt:9 Reply

    Done
  16. Christian Kuhn voted on patch set 4 V +1 CR +1 01/20/23, 13:02

  17. Stefan Bürk voted on patch set 4 V +2 CR +2 01/20/23, 13:05

  18. Stefan Bürk merged patch set 5 01/20/23, 13:05