77513[BUGFIX] Make http_makelinks more fault tolerant
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Thomas Hohn uploaded patch set 1 01/20/23, 08:48
-
core-ci voted on patch set 1 V +1 01/20/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36299
-
Christian Kuhn voted on patch set 1 V +1 CR +1 01/22/23, 16:21
-
Claus Due commented on patch set 1 01/22/23, 20:35
Use case of handling unexpected return values from parse_url is fully acknowledged and I agree with this method of handling it. I abstain from voting -1 or +1 since my only comment on this is a readability nit-pick. Feel free to disregard ;)ContentObjectRenderer.php:3578Minor nitpick: could we invert this so: if (!is_array($linkParts)) { // short stuff here } else { // longer part here } Just for readability. -
Stefan Bürk uploaded patch set 2
CR +1V +101/22/23, 21:01 -
Stefan Bürk commented on patch set 2 01/22/23, 21:03
ContentObjectRenderer.php:3578ReplySolve with a slightly other approach, but still taking the invert/flip into account. -
core-ci voted on patch set 2 V +1 01/22/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36445
-
Christian Kuhn voted on patch set 2 V +1 CR +1 01/22/23, 21:10
-
Stefan Bürk voted on patch set 2 V +2 CR +2 01/22/23, 21:11
-
Stefan Bürk merged patch set 3 01/22/23, 21:11