Review main Merged

77515[BUGFIX] Do not trigger setUpdateSignal in CLI

Benni Mack CR +2 V +2 Easy +5 −0 updated 01/20/23, 12:27

Commit message

This change prevents triggering
a updateModuleData in CLI, which happens
when e.g. running a importer on CLI
which then updates Slugs automatically
via CLI, which in turn trigger
setUpdateSignal in EXT:redirects'
SlugService.php.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Benni Mack uploaded patch set 1 01/20/23, 11:01

  2. Benni Mack updated the commit message in patch set 2 01/20/23, 11:04

  3. Daniel Goerz voted on patch set 2 V +1 CR +1 01/20/23, 11:06

  4. Benni Mack commented on patch set 3 CR +1 V +1 01/20/23, 11:07

    Published edit on patch set 2.
  5. core-ci voted on patch set 1 V +1 01/20/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36331

  6. core-ci voted on patch set 2 V +1 01/20/23, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36332

  7. core-ci voted on patch set 3 V +1 01/20/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36333

  8. Andreas Kienast voted on patch set 3 CR +1 01/20/23, 11:32

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 01/20/23, 11:51

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 01/20/23, 12:20

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 01/20/23, 12:27

  12. Christian Kuhn merged patch set 4 01/20/23, 12:27