Review main Merged

77519[TASK] Prevent superflous SQL queries in HMENU

Christoph Lehmann CR +2 V +2 Easy +10 −2 updated 01/23/23, 18:48

Commit message

When isSubMenu() decides, that the current page has no subpages, then do not try to fetch its subpages.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1626

Show 1 earlier messages
  1. Christoph Lehmann uploaded patch set 1 01/20/23, 13:28

  1. Christoph Lehmann updated the commit message in patch set 2 01/20/23, 13:31

  2. core-ci voted on patch set 1 V -1 01/20/23, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36352

  3. core-ci voted on patch set 2 V -1 01/20/23, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36353

  4. Christoph Lehmann uploaded patch set 3 V -1 01/20/23, 14:08

  5. core-ci voted on patch set 3 V -1 01/20/23, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36365

  6. Christoph Lehmann uploaded patch set 4 V -1 01/20/23, 23:01

  7. Christoph Lehmann updated the commit message in patch set 5 01/20/23, 23:03

  8. core-ci voted on patch set 4 V -1 01/20/23, 23:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36397

  9. core-ci voted on patch set 5 V -1 01/20/23, 23:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36398

  10. Christoph Lehmann uploaded patch set 6 V -1 01/21/23, 16:42

  11. core-ci voted on patch set 6 V -1 01/21/23, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36412

  12. Christoph Lehmann uploaded patch set 7 V -1 01/21/23, 22:10

  13. core-ci voted on patch set 7 V -1 01/21/23, 22:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36414

  14. Christoph Lehmann uploaded patch set 8 V -1 01/21/23, 23:24

  15. core-ci voted on patch set 8 V +1 01/21/23, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36415

  16. Christoph Lehmann updated the commit message in patch set 9 V +1 01/21/23, 23:40

  17. core-ci voted on patch set 9 V +1 01/21/23, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36416

  18. Christoph Lehmann commented on patch set 9 01/21/23, 23:51

    The change is ready for review. Patchset 7 is an attempt to re-use the "submenu pages cache entry" of isSubMenu() in order to not fetch subpages twice for pages that have subpages. Sadly some tests fail. Maybe someone else can have a look at it.
  19. Christian Kuhn commented on patch set 9 01/23/23, 17:42

    similar thing as with a previous patch: i'd prefer to not backport this to v11 for now, maybe later in case the patch runs a while with v12 successfully. i'll remove v11 from the releases list for now.
  20. Christian Kuhn updated the commit message in patch set 10 V +1 01/23/23, 17:42

  21. Christian Kuhn voted on patch set 10 V +1 CR +1 01/23/23, 17:42

  22. core-ci voted on patch set 10 V +1 01/23/23, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36485

  23. Anja Leichsenring voted on patch set 10 V +1 CR +1 01/23/23, 18:39

  24. Stefan Bürk voted on patch set 10 V +2 CR +2 01/23/23, 18:48

  25. Stefan Bürk merged patch set 11 01/23/23, 18:48