Review main Merged

77523[TASK] Cleanup thumbnails related code in FileBrowser

Oli Bartsch CR +2 V +2 Normal +45 −111 updated 01/20/23, 20:22

Commit message

This cleans up FileBrowser code, related to the
thumbnails functionality:

- Removes the copied code from #99579 again
- Removes forelast usage of BackendUtility::getModuleData()
- Resolves duplicate Request parameter evaluation
- Simplifies "script url" generation

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 01/20/23, 15:41

  2. core-ci voted on patch set 1 V -1 01/20/23, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36373

  3. Oli Bartsch uploaded patch set 2 V -1 01/20/23, 16:35

  4. core-ci voted on patch set 2 V +1 01/20/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36374

  5. Benni Mack voted on patch set 2 V +1 CR +1 01/20/23, 16:49

  6. Georg Ringer voted on patch set 2 V +2 CR +2 01/20/23, 20:22

  7. Georg Ringer merged patch set 3 01/20/23, 20:22