Review main Merged

77529[TASK] Use more native types in ext:frontend tests

Torben Hansen CR +2 V +2 Normal +30 −149 updated 01/22/23, 19:36

Commit message

* Use strict typed properties
* Use union types for function parameters where suitable
* Use mixed type where suitable
* Remove doc header for constant LANGUAGE_PRESETS
* Remove non-informal class doc headers

As a result of the change, 3 entries from phpstan-baseline.neon
were be removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 34

Show 14 more files

Review log 45

  1. Torben Hansen uploaded patch set 1 01/22/23, 18:36

  2. core-ci voted on patch set 1 V +1 01/22/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36429

  3. Georg Ringer voted on patch set 1 V +1 CR +1 01/22/23, 19:26

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 01/22/23, 19:36

  5. Christian Kuhn merged patch set 2 01/22/23, 19:36