Review main Merged

77530[TASK] Rework wording in EXT:tstemplate

Jasmina Ließmann CR +2 V +2 Hard +408 −431 updated 01/23/23, 14:38

Commit message

Use unique language keys for each submodule of EXT:tstemplate.
Update texts, headlines and info box notes.

Rename submodules "Override TypoScript" to "Edit TypoScript record"
and "TypoScript Tree" to "Active TypoScript".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 28

Show 8 more files

Review log 1318

  1. Jasmina Ließmann uploaded patch set 1 01/22/23, 20:12

  2. Jasmina Ließmann uploaded patch set 2 01/22/23, 20:16

  3. core-ci voted on patch set 1 V -1 01/22/23, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36439

  4. core-ci voted on patch set 2 V -1 01/22/23, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36440

  5. Jasmina Ließmann uploaded patch set 3 V -1 01/22/23, 20:25

  6. Jasmina Ließmann updated the commit message in patch set 4 01/22/23, 20:25

  7. Jasmina Ließmann uploaded patch set 5 01/22/23, 20:26

  8. core-ci voted on patch set 5 V -1 01/22/23, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36443

  9. Christian Kuhn uploaded patch set 6 V -1 01/22/23, 21:08

  10. core-ci voted on patch set 6 V -1 01/22/23, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36446

  11. Georg Ringer commented on patch set 6 CR -1 01/23/23, 06:54

    we are loosing all translations if we change the key - without checking in detail - it is fine if the content of the translation changes as well but if is just for sake of nicer key, please don't
  12. Christian Kuhn commented on patch set 6 01/23/23, 10:10

    Reply

    Yeah. We're aware of the impact on translators. In this case, we decided to go with a major label cleanup for these reasons: * We added and removed quite a few labels with v12 already, I guess 30-40% have been touched with previous patches already. * We're improving separation of the label files and streamline them. * There are more upcoming changes on labels, fine tuning and we'll have to add some more for upcoming features. * The module undergoes a major refactoring with a lot of new and streamline functionality. All in all, we think, it is currently a good opportunity to streamline the labels at this point since the module is a rewrite in all areas and we're changing pretty much all wording. I'd say it's the best option to do this now.
  13. Christian Kuhn uploaded patch set 7 CR -1 V -1 01/23/23, 14:18

  14. core-ci voted on patch set 7 V +1 01/23/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36472

  15. Christian Kuhn voted on patch set 7 V +1 CR +1 01/23/23, 14:25

  16. Stefan Bürk voted on patch set 7 V +1 CR +1 01/23/23, 14:37

  17. Christian Kuhn voted on patch set 7 V +2 CR +2 01/23/23, 14:38

  18. Christian Kuhn merged patch set 8 01/23/23, 14:38