77530[TASK] Rework wording in EXT:tstemplate
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 28
- typo3/sysext/core/Tests/Acceptance/Application/Site/SiteModuleCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+14 −14
- typo3/sysext/fluid_styled_content/Documentation/FirstSteps/DefaultTemplate.rst+1 −1
- typo3/sysext/fluid_styled_content/Documentation/screenshots.json+1 −1
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/ObjectBrowserController.php+3 −3
- typo3/sysext/tstemplate/Configuration/Backend/Modules.php+11 −6
- typo3/sysext/tstemplate/Resources/Private/Language/locallang.xlf+36 −51
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_analyzer.xlf+5 −5
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_ceditor.xlf+10 −10
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_info.xlf+19 −67
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_mod.xlfdeleted+0 −17
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_objbrowser.xlf+81 −77
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_records_overview.xlfnew+26 −0
- typo3/sysext/tstemplate/Resources/Private/Partials/ConstantEditorOptions.html+2 −2
- typo3/sysext/tstemplate/Resources/Private/Partials/NoRecordFound.htmlrenamed+15 −14
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserConditions.html+3 −3
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserOptions.html+4 −4
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTree.html+2 −2
- typo3/sysext/tstemplate/Resources/Private/Partials/ObjectBrowserTreePanel.html+10 −2
Show 8 more files
- typo3/sysext/tstemplate/Resources/Private/Templates/Analyzer.html+4 −4
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorMain.html+7 −15
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorNoTemplate.html+13 −9
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyMain.html+11 −11
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyNoTemplate.html+13 −9
- typo3/sysext/tstemplate/Resources/Private/Templates/ObjectBrowserEdit.html+43 −34
- typo3/sysext/tstemplate/Resources/Private/Templates/ObjectBrowserMain.html+63 −59
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateRecordsOverview.html+6 −6
Review log 1318
-
Jasmina Ließmann uploaded patch set 1 01/22/23, 20:12
-
Jasmina Ließmann uploaded patch set 2 01/22/23, 20:16
-
core-ci voted on patch set 1 V -1 01/22/23, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36439
-
core-ci voted on patch set 2 V -1 01/22/23, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36440
-
Jasmina Ließmann uploaded patch set 3
V -101/22/23, 20:25 -
Jasmina Ließmann updated the commit message in patch set 4 01/22/23, 20:25
-
Jasmina Ließmann uploaded patch set 5 01/22/23, 20:26
-
core-ci voted on patch set 5 V -1 01/22/23, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36443
-
Christian Kuhn uploaded patch set 6
V -101/22/23, 21:08 -
core-ci voted on patch set 6 V -1 01/22/23, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36446
-
Georg Ringer commented on patch set 6 CR -1 01/23/23, 06:54
we are loosing all translations if we change the key - without checking in detail - it is fine if the content of the translation changes as well but if is just for sake of nicer key, please don't -
Christian Kuhn commented on patch set 6 01/23/23, 10:10
Reply
Yeah. We're aware of the impact on translators. In this case, we decided to go with a major label cleanup for these reasons: * We added and removed quite a few labels with v12 already, I guess 30-40% have been touched with previous patches already. * We're improving separation of the label files and streamline them. * There are more upcoming changes on labels, fine tuning and we'll have to add some more for upcoming features. * The module undergoes a major refactoring with a lot of new and streamline functionality. All in all, we think, it is currently a good opportunity to streamline the labels at this point since the module is a rewrite in all areas and we're changing pretty much all wording. I'd say it's the best option to do this now. -
Christian Kuhn uploaded patch set 7
CR -1V -101/23/23, 14:18 -
core-ci voted on patch set 7 V +1 01/23/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36472
-
Christian Kuhn voted on patch set 7 V +1 CR +1 01/23/23, 14:25
-
Stefan Bürk voted on patch set 7 V +1 CR +1 01/23/23, 14:37
-
Christian Kuhn voted on patch set 7 V +2 CR +2 01/23/23, 14:38
-
Christian Kuhn merged patch set 8 01/23/23, 14:38