Review main Merged

77533[BUGFIX] Do not access tce_db route directly

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 01/23/23, 13:14

Commit message

In case only one cache clear option is available
in the toolbar (no dropdown), clicking on the icon
previously led to a blank page, since the corresponding
JS event listener did not get called and the tce_db
route was called directly.

This is now fixed by using the correct class to notify
the event listener, which will call tce_db in an ajax request.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 01/23/23, 12:11

  2. core-ci voted on patch set 1 V +1 01/23/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36462

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 01/23/23, 12:23

  4. Benni Mack voted on patch set 1 V +1 CR +1 01/23/23, 13:04

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 01/23/23, 13:05

  6. Oli Bartsch merged patch set 2 01/23/23, 13:05

  7. Oli Bartsch commented on patch set 2 01/23/23, 13:14

    Note: Backport not necessary! The bug only exists in main and was most likely introduced with #98307.